Skip to content

scripts: merge removeAnchors.sh and resetSolutions.sh - #457

Merged
milesfrain merged 3 commits into
purescript-contrib:masterfrom
softmoth:issue403
Sep 6, 2023
Merged

milesfrain merged 3 commits into
purescript-contrib:masterfrom
softmoth:issue403

Conversation

@softmoth

Copy link
Copy Markdown

Keeping it all in a single scripts/prepareExercises.sh avoids duplication.

Also remove the complex file finding; simply getting all source files within the exercises directory is a perfect fit for what is needed. This fixes Issue #430.

softmoth and others added 3 commits August 31, 2023 19:05
Keeping it all in a single `scripts/prepareExercises.sh` avoids
duplication.

Also remove the complex file finding; simply getting all source
files within the `exercises` directory is a perfect fit for what is
needed. This fixes Issue purescript-contrib#430.
@milesfrain

milesfrain commented Sep 6, 2023 •

Copy link
Copy Markdown
Member

Thanks for the PR.

I can't think of a situation where we need to selectively choose which operation to run, so let's just simplify things further and always do everything. I went ahead and pushed an update to your branch here, and also updated CI to run your new script.

The reason for the original complicated FIND_FILES_PATTERN regex is to not accidentally edit anything in the other directories found within each chapter's directory (e.g. dist, node_modules, output, etc.). But there's another simple way to just point to src and test, so I went ahead with making that edit too.

This runs on Linux for me.
Are there any Windows or Mac folks who can verify this still works for them too?

@softmoth

softmoth commented Sep 6, 2023 •

Copy link
Copy Markdown
Author

That looks great. I think there are some old finds that don't -print by default, that's why I had the parentheses and the explicit -print, but probably it's not needed if it works on OS X and FreeBSD as you've done it. Maybe people on #396 and #443 could help testing, since those are related?

@milesfrain
milesfrain merged commit 427f698 into purescript-contrib:master Sep 6, 2023
@softmoth
softmoth deleted the issue403 branch September 9, 2023 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants