Enable SQLAlchemy update and delete compliance tests - #750
Merged
Conversation
laughingman7743
marked this pull request as ready for review
August 11, 2026 06:43
This was referenced Aug 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WHAT
Re-enable the upstream SQLAlchemy SimpleUpdateDeleteTest for Athena Iceberg tables.
Return no DB API description for INSERT, UPDATE, DELETE, and MERGE statements while preserving their UpdateCount as rowcount.
Add regression assertions for the four DML statement types.
Related to #736.
WHY
Athena returns DML UpdateCount responses with result-set metadata even though the statements do not return rows.
PyAthena exposed that metadata as cursor.description, so SQLAlchemy classified UPDATE and DELETE results as row-returning results.
Suppressing the DML description aligns the cursor with DB API behavior and allows the standard SQLAlchemy update and delete tests to run without weakening their assertions.
TESTING