Skip to content

Navigation Menu

Appearance settings

View all features
- BY COMPANY SIZE
  Enterprises
  Small and medium teams
  Startups
  Nonprofits
- BY USE CASE
  App Modernization
  DevSecOps
  DevOps
  CI/CD
  View all use cases
- BY INDUSTRY
  Healthcare
  Financial services
  Manufacturing
  Government
  View all industries
View all solutions
- EXPLORE BY TOPIC
  AI
  Software Development
  DevOps
  Security
  View all topics
- EXPLORE BY TYPE
  Customer stories
  Events & webinars
  Ebooks & reports
  Business insights
  GitHub Skills
- SUPPORT & SERVICES
  Documentation
  Customer support
  Community forum
  Trust center
  Partners
View all resources
- COMMUNITY
  GitHub SponsorsFund open source developers
- PROGRAMS
  Security Lab
  Maintainer Community
  GitHub Stars
  Archive Program
- REPOSITORIES
  Topics
  Trending
  Collections
- ENTERPRISE SOLUTIONS
  Enterprise platformAI-powered developer platform
- AVAILABLE ADD-ONS
  GitHub Advanced SecurityEnterprise-grade security features
  Copilot for BusinessEnterprise-grade AI features
  Premium SupportEnterprise-grade 24/7 support
Pricing

Appearance settings

You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session. You switched accounts on another tab or window. Reload to refresh your session.

Dismiss alert

Uh oh!

There was an error while loading. Please reload this page.

pybind / pybind11 Public

Notifications You must be signed in to change notification settings
Fork 2.3k
Star 18k

Code
Issues 570
Pull requests 145
Discussions
Actions
Wiki
Security and quality
Insights

Additional navigation options

Code
Issues
Pull requests
Discussions
Actions
Wiki
Security and quality
Insights

smart_holder trampoline shared_from_this support - #3023

#3023

Merged

rwgk merged 67 commits into

pybind:smart_holderpybind/pybind11:smart_holderfrom

rwgk:sh_shared_from_thisrwgk/pybind11:sh_shared_from_thisCopy head branch name to clipboard

Jun 30, 2021

Conversation Commits67 (67)Checks Files changed

Merged

smart_holder trampoline shared_from_this support#3023
rwgk merged 67 commits into
pybind:smart_holderfrom
rwgk:sh_shared_from_this

Commits

Commits on Jun 29, 2021

Isolating shared_from_this tests from test_smart_ptr (minimal changes).
rwgk
committed
d9ac283
Experiments: 1. disabling enable_shared_from_this, 2. using smart_holder in test_class_sh_shared_from_this.cpp
rwgk
committed
007ab63
Breaking up test_shared_ptr_from_this_and_references into smaller subtests. Skipping the only test that generates an ASAN heap-use-after-free.
rwgk
committed
4e993f7
Restoring init_holder overload for std::enable_shared_from_this and original tests/test_smart_ptr.py.
rwgk
committed
bfaa006
static_assert in from_raw_ptr_take_ownership, to be tested.
rwgk
committed
1fc5a02
enable_shared_from_this_from_raw_ptr_take_ownership_guard: better static_assert that also triggers for derived classes.
rwgk
committed
4a9f6ea
Adding from_raw_pointer_take_ownership_or_shared_from_this().
rwgk
committed
20aa407
Adding test_class_sh_shared_from_this.cpp to tests/CMakeLists.txt.
rwgk
committed
4d403f3
Fully emulating type_caster_base-related behavior: trying shared_from_this also for unowned pointees.
rwgk
committed
3d603f2
Experiment: commenting out test_class_sh_shared_from_this.
rwgk
committed
60fd973
Experiment: effectively undoing all shared_from_this modifications.
rwgk
committed
881b25c
Experiment: undoing even more.
rwgk
committed
f5ac855
Experiment: restoring original smart_holder_type_casters.h from smart_holder branch.
rwgk
committed
bd13ad9
Revert "Experiment: restoring original smart_holder_type_casters.h from smart_holder branch."
rwgk
committed
8bb208a
Revert "Experiment: undoing even more."
rwgk
committed
e45ab22
Revert "Experiment: effectively undoing all shared_from_this modifications."
rwgk
committed
5817c83
Revert "Experiment: commenting out test_class_sh_shared_from_this."
rwgk
committed
8fb1210
Copying in shared_from_this_custom_deleters.cpp from github.com/rwgk, with adjustments.
rwgk
committed
86e2024
Explictly discarding [[nodiscard]] to avoid MSVC CI failures.
rwgk
committed
2b46052
Inserting `#ifdef` to preempt Windows fatal exception.
rwgk
committed
97d4dab
Adding shared_ptr_reset_and_rescue_pointee_model_proof_of_concept.
rwgk
committed
cad91e7
MSVC 2015 compatibility.
rwgk
committed
9845f69
WIP snapshot.
rwgk
committed
df25405
WIP snapshot: std::get_deleter experiment.
rwgk
committed
fdc91f8
WIP snapshot: replacing `std::shared_ptr<bool> flag_ptr` with simple `bool armed_flag`.
rwgk
committed
d704167
Fixing oversight (clang-tidy error).
rwgk
committed
307766f
Inserting `const_cast` for `std::get_deleter` return, to keep Ubuntu 20 GCC 6.3.0 happy.
rwgk
committed
79c711e
Adding back explicit but default copy constructor, to keep some older compilers happy.
rwgk
committed
87756ca
Replacing virtual `guarded_operator_call` with non-virtual `guarded_delete`.
rwgk
committed
994800b
Fixing silly oversight (discovered while creating PR #3041).
rwgk
committed
d3104be
Fixing `git rebase -X theirs` accident.
rwgk
committed
2745c31
First attempt to make shared_from_this and trampolines play nicely. Passes all pybind11 and PyCLIF unit tests ASAN clean, but not the open_spiel iterated_prisoners_dilemma_test.
rwgk
committed
86a4fb7
First fully successful attempt to make `shared_from_this` and trampolines play nicely.
rwgk
committed
1c98886
Disabling debugging call of `weak_from_this` for C++ < 17.
rwgk
committed
69fcb36
Trying again, to get around unused parameter warnings-as-erros.
rwgk
committed
691127c
Two minor platform-specific fixes. Using static_cast instead of reinterpret_cast.
rwgk
committed
ef5bc6d
nodiscard fix.
rwgk
committed
76deebe
Adding tests involving stashing `shared_ptr`s. WIP.
rwgk
committed
c7c257f
Resolving gcc warning-as-error (many versions, old and new).
rwgk
committed
da812cd
Attempts to side-step various platform-specific issues.
rwgk
committed
c469587
Adding `test_pass_released_shared_ptr_as_unique_ptr`, exercising new guard in smart_holder_type_casters.h.
rwgk
committed
a17ad73
Minor clang-tidy fix.
rwgk
committed
eb7c51f
Leveraging new `noop_deleter_acting_as_weak_ptr_owner` to retrieve released `vptr`.
rwgk
committed
3f190fb
Partial cleanup of tests. WIP. The cleanup uncovered a major problem.
rwgk
committed
bd40c4c
Applying clang-tidy suggested fixes.
rwgk
committed
1d319b7
smart_holder_poc.h: type-erase raw_ptr before passing to shared_ptr::reset, to not trigger populating the shared_from_this weak_ptr. This way the only way the weak_ptr is populated is through loade…
rwgk
committed
d68094d
Simpler and safe implementation based on new requirement: C++ (outside of the Python object) needs to hold a shared_ptr before shared_from_this is called. This is more similar to the existing imple…
rwgk
committed
d94e348
Automatic clang-tidy fixes.
rwgk
committed
1cb657d
Adding // NOLINT for clang-tidy.
rwgk
committed
4f88eac
Adding test_pure_cpp_sft_raw_ptr (with 3 TODO: Fix), test_pure_cpp_sft_shd_ptr (works as desired).
rwgk
committed
78ddb1a
Preparation for being smarter about casting to `void *` to evade to shared_from_this mechanism.
rwgk
committed
75fcf5f
Use casting to `void *` to evade to shared_from_this mechanism only if `pointee_depends_on_holder_owner`, but currently only for `from_raw_ptr_take_ownership`.
rwgk
committed
50ac3ef
Resolving TODOs for `from_unique_ptr` `void_cast_raw_ptr`. Adding test to exercise the path through `cast`. The path through init.h is missing a test that would fail if the flag is incorrect. The p…
rwgk
committed
8870251
Removing experimental code from here. Will be moved to https://github.com/rwgk/rwgk_tbx.
rwgk
committed
73e8d71
Cleaning out debug code.
rwgk
committed
7fc8313
Updating Catch version to latest, in hopes of resolving the GHA download issue affecting all MSVC builds.
rwgk
committed
7031875
Revert "Updating Catch version to latest, in hopes of resolving the GHA download issue affecting all MSVC builds."
rwgk
committed
1528efb
Adding a few comments after review by @laramiel.
rwgk
committed
0956874
A couple more enhancements based on feedback by @laramiel.
rwgk
committed
3c69fee
This change fixes the 6 unit tests in
rwgk
committed
9c84800
Adding unit test: test_multiple_registered_instances_for_same_pointee
rwgk
committed
7663896
Adding unit tests: 2 x test_std_make_shared_factory
rwgk
committed
f772ccd
Fixing `git rebase -X theirs smart_holder` issue.
rwgk
committed
815238c
Adding test_multiple_registered_instances_for_same_pointee_leak. Subtle changes in smart_holder_type_caster_load, trying to work on weak_ptr for shared_ptr_trampoline_self_life_support, but that di…
rwgk
committed
0043fe5
Adding test_multiple_registered_instances_for_same_pointee_recursive.
rwgk
committed
4c64a9e
Converting C assert to pybind11_fail (to play safe).
rwgk
committed
08e9c60
Small reduction in code complexity.
rwgk
committed
45fbdfc

Footer

© 2026 GitHub, Inc.

Footer navigation

Terms
Privacy
Security
Status
Community
Docs
Contact

You can’t perform that action at this time.