Don't use shell to run vagrant subprocess - #112
Merged
Conversation
konstruktoid
left a comment
konstruktoid
left a comment
Collaborator
There was a problem hiding this comment.
should we ensure a shell isn't used by setting shell=False?
i know it's the default, but just to be on the safe side?
Collaborator
Author
That's indeed a good question. I was relying on the default value, but yeah, the default can always be changed later. |
konstruktoid
approved these changes
Mar 30, 2022
konstruktoid
left a comment
konstruktoid
left a comment
Collaborator
There was a problem hiding this comment.
I would prefer shell=False, but otherwise lgtm
ssbarnea
approved these changes
Mar 30, 2022
ssbarnea
changed the title
Member
|
@apatard please rebase and merge once passing. |
There's no need to have an overhead of a shell and it's often considered bad practice, so convert all subprocess calls to not use a shell. Signed-off-by: Arnaud Patard <apatard@hupstream.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There's no need to have an overhead of a shell and it's often
considered bad practice, so convert all subprocess calls to
not use a shell.
Signed-off-by: Arnaud Patard apatard@hupstream.com