Skip to content

Better dtype preservation for rolling mean on dask array - #7063

Merged
max-sixty merged 4 commits into
pydata:mainfrom
slevang:rolling-dtype
Sep 22, 2022
Merged

max-sixty merged 4 commits into
pydata:mainfrom
slevang:rolling-dtype

Conversation

@slevang

@slevang slevang commented Sep 21, 2022 •

Copy link
Copy Markdown
Contributor

This just tests to make sure we at least get the same dtype whether we have a numpy or dask array.

Comment thread xarray/core/rolling.py Outdated
Co-authored-by: Deepak Cherian <dcherian@users.noreply.github.com>
@max-sixty

Copy link
Copy Markdown
Collaborator

Thanks @slevang ! Feel free to add a whatsnew, no requirement to though, we'll merge this shortly either way

@max-sixty max-sixty added the plan to merge Final call for comments label Sep 21, 2022
@max-sixty
max-sixty merged commit 1f4be33 into pydata:main Sep 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

plan to merge Final call for comments topic-rolling

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Rolling mean on dask array does not preserve dtype

3 participants