Repository navigation
feat(notifications): combine native desktop and upstream alerts - #583
Conversation
Implemented with GPT-6 Astra in Codex App. (cherry picked from commit c8be74b)
Implemented with GPT-6 Astra in Codex App. (cherry picked from commit ad44aad)
Implemented with GPT-6 Astra in Codex App. (cherry picked from commit f830a8c)
…ions Update the desktop settings fixture for the new preference fields. Implemented with GPT-6 Astra in Codex App. (cherry picked from commit 6f8a3d4)
…k-through Implemented with GPT-6 Astra in Codex App. (cherry picked from commit 06bfa08)
Implemented with GPT-6 Astra in Codex App. (cherry picked from commit 65326a1)
Implemented with GPT-6 Astra in Codex App. (cherry picked from commit ab8d6bd)
Implemented with GPT-6 Astra in Codex App. (cherry picked from commit 72e2c11)
Implemented with GPT-6 Astra in Codex App. (cherry picked from commit 4801ea1)
Keep pending notification objects alive until handled and release them when the desktop scope closes. Add collection-based lifetime regression coverage. Implemented with GPT-6 Astra in Codex App. (cherry picked from commit a39c56a)
Co-authored-by: maria-rcks <254055478+maria-rcks@users.noreply.github.com> (cherry picked from commit 0e0ddaeedf30698bec131caf040a8e8d7b2e3f37)
(cherry picked from commit 42b6bcc6f59bd0369377746b0f2ef370c275b624)
Co-authored-by: maria-rcks <maria@kuuro.net> (cherry picked from commit 6e5e986f15b3cbec3588646ddf216f00b4301785)
… delivery Build on ALGORITHM-0's Pylon PR #424 native delivery, category preferences, settings and tests, complementing upstream #11481, #11570 and #11569. Preserve the ten original #424 commits and their authorship. Use one event reconciler with Pylon completion semantics, live-state fencing, turn-aware deduplication, bounded native lifetime, and acknowledged navigation for a recreated renderer. Add upstream browser alerts, sounds, in-app notices and badges while retaining Pylon desktop defaults. Co-authored-by: ALGORITHM-0 <luke.t.walker.10@gmail.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Thread transfer impact✅ Thread transfer remains within every enforced ceiling.
Baseline: Scenario and decoded snapshot size10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.
Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed. |
|
Browser verification evidence, captured against isolated task-owned state at BeforeAfterCompletion delivery23-second recording of completion delivery and click-through: delivery.mp4 |



Pylon needs one notification system across desktop and browser clients. This combines the native desktop work from #424 with upstream's browser alerts, sounds, in-app notices and badges, while preserving Pylon's desktop defaults and completion semantics.
Credit
ALGORITHM-0's work in #424 is a substantial foundation of this implementation. The native Electron delivery layer, per-event preferences, settings, notification lifetime handling and tests are retained and extended. All ten original commits preserve ALGORITHM-0's authorship, and the integration commit also includes a Co-authored-by trailer. This work complements upstream's additions rather than replacing that contribution.
Upstream contributions are preserved with author attribution and source trailers:
0e0ddaeedf30698bec131caf040a8e8d7b2e3f37— maria / maria-rcks, #11481.42b6bcc6f59bd0369377746b0f2ef370c275b624— Bilal Bakr, #11570.6e5e986f15b3cbec3588646ddf216f00b4301785— Bilal Bakr and maria-rcks, #11569.Comparative review
The recommendation is a combined implementation: each source contributes capabilities the other lacks. Neither should land unchanged. #424 remains an open draft and has never been merged.
Behavior and fixes
A single reconciler prevents duplicate delivery, silently re-primes after reconnect, detects successive completed turns without an intermediate running snapshot, and preserves interrupted/session-only completion states. Archived threads and older rollback completions remain silent. Native notifications are replaced per thread and capped at 128 retained objects. Click targets remain in main until a ready renderer acknowledges navigation, including window recreation.
Desktop alerts and category preferences remain on by default; custom sounds, browser alerts and in-app notices are opt-in. Preferences reset correctly. Native desktop, browser permission handling, sound, toasts and badges share the same event decisions. No mobile push or closed-client background delivery is added.
Validation
34b45525070f46cf811e32ba776e807d7286a98f, including general/server tests and Windows/Linux packaged smoke. Codesmith is inactive/skipped; no automated review findings were posted.Bounded upstream head:
6d1d549441be84f19696ab59ed7e2fbf305280d4. Only the three notification sources above are included; the global upstream review cursor is unchanged.Completes the implementation work proposed in #424. It remains open until this replacement integration is approved and merged. No release or installation performed.
Implemented with GPT-6 in Codex.
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.