Repository navigation
fix(antigravity): avoid spawning runtimes for health checks - #586
Merged
Merged
Conversation
…folders (#12008) The health probe launched the PyInstaller ACP binary every minute and force killed it, leaving about 1 GB of _MEI files per run. The probe now resolves the install on disk without spawning. Each ACP process gets its own temp directory under the profile that is removed when the runtime closes, and the driver sweeps the profile temp root on create. Continues #11657 by Vita Skacel. Owned temp directory approach from #9626 by ariszz. Co-authored-by: Vita Skacel <skacel.vita@gmail.com> Co-authored-by: Claude Fable 5.1 <noreply@anthropic.com> (cherry picked from commit 8c18b5bb21a5349fbadba8c77456ea34c41b7339)
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
Thread transfer impact✅ Thread transfer remains within every enforced ceiling.
Baseline: Scenario and decoded snapshot size10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.
Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed. |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Antigravity health checks launch a PyInstaller runtime repeatedly, which can leave large extraction folders after forced shutdown. Resolve installation metadata without starting the runtime, and isolate each actual ACP runtime in its own scoped temp directory.
Adopts upstream
8c18b5bb21a5349fbadba8c77456ea34c41b7339(#12008), preserving original authorship and credit to VitaCodez and ariszz described in the upstream PR. Pylon intentionally excludes the blanket startup sweep: another driver/server may still own files beneath the same profile. Cleanup removes only the current runtime's acquired directory after child teardown. Abrupt termination or failed Windows cleanup can leave directories; system temp is untouched. The probe returns only the installation metadata consumed by provider health, not synthetic protocol capabilities.Validation: 61 focused driver, auth-environment and provider tests pass; server typecheck, scoped lint/formatting and diff checks pass. Tests cover repeated non-spawning probes, resolution failure, separate runtime directories, teardown cleanup and preservation of unowned files. Platform environment mapping is tested; no real Windows Antigravity binary was exercised. No wire/client behavior changes; session authentication and model refresh still use actual runtimes.
Part of #585. Frozen upstream head
6d1d549441be84f19696ab59ed7e2fbf305280d4; global cursor unchanged. No release or installation.Implemented with GPT-6 in Codex.
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.