Skip to content

fix(antigravity): avoid spawning runtimes for health checks - #586

Merged
rynfar merged 2 commits into
pylonfrom
upstream/2026-09-17-antigravity-health
Sep 17, 2026
Merged

rynfar merged 2 commits into
pylonfrom
upstream/2026-09-17-antigravity-health

Conversation

@rynfar

@rynfar rynfar commented Sep 17, 2026 •

Copy link
Copy Markdown
Collaborator

Antigravity health checks launch a PyInstaller runtime repeatedly, which can leave large extraction folders after forced shutdown. Resolve installation metadata without starting the runtime, and isolate each actual ACP runtime in its own scoped temp directory.

Adopts upstream 8c18b5bb21a5349fbadba8c77456ea34c41b7339 (#12008), preserving original authorship and credit to VitaCodez and ariszz described in the upstream PR. Pylon intentionally excludes the blanket startup sweep: another driver/server may still own files beneath the same profile. Cleanup removes only the current runtime's acquired directory after child teardown. Abrupt termination or failed Windows cleanup can leave directories; system temp is untouched. The probe returns only the installation metadata consumed by provider health, not synthetic protocol capabilities.

Validation: 61 focused driver, auth-environment and provider tests pass; server typecheck, scoped lint/formatting and diff checks pass. Tests cover repeated non-spawning probes, resolution failure, separate runtime directories, teardown cleanup and preservation of unowned files. Platform environment mapping is tested; no real Windows Antigravity binary was exercised. No wire/client behavior changes; session authentication and model refresh still use actual runtimes.

Part of #585. Frozen upstream head 6d1d549441be84f19696ab59ed7e2fbf305280d4; global cursor unchanged. No release or installation.

Implemented with GPT-6 in Codex.


View with [code]smith Autofix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need. Autofix is disabled.

t3dotgg and others added 2 commits September 16, 2026 23:33
…folders (#12008)

The health probe launched the PyInstaller ACP binary every minute and force killed it, leaving about 1 GB of _MEI files per run. The probe now resolves the install on disk without spawning. Each ACP process gets its own temp directory under the profile that is removed when the runtime closes, and the driver sweeps the profile temp root on create.

Continues #11657 by Vita Skacel. Owned temp directory approach from #9626 by ariszz.

Co-authored-by: Vita Skacel <skacel.vita@gmail.com>
Co-authored-by: Claude Fable 5.1 <noreply@anthropic.com>
(cherry picked from commit 8c18b5bb21a5349fbadba8c77456ea34c41b7339)
@vercel

vercel Bot commented Sep 17, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
pylon-marketing Ready Ready Preview Sep 17, 2026 5:37am UTC

@github-actions github-actions Bot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. size:L labels Sep 17, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Thread transfer impact

✅ Thread transfer remains within every enforced ceiling.

Provider Metric Main baseline This PR Impact PR ceiling
Codex Total thread wire 13.9 KiB 13.9 KiB +14 B (+0.1%) 15.1 KiB ✅
Codex Thread snapshot wire 7.2 KiB 7.2 KiB −6 B (−0.1%) 7.3 KiB ✅
Codex Live turn WebSocket wire 6.7 KiB 6.7 KiB +20 B (+0.3%) 7.8 KiB ✅
Codex Live turn WebSocket decoded 58.0 KiB 58.0 KiB +44 B (+0.1%) 66.4 KiB ✅
Codex Live turn messages 8 9 +1 (+12.5%) 21 ✅
Claude Total thread wire 14.1 KiB 14.1 KiB +23 B (+0.2%) 15.1 KiB ✅
Claude Thread snapshot wire 7.2 KiB 7.2 KiB +4 B (+0.1%) 7.3 KiB ✅
Claude Live turn WebSocket wire 6.8 KiB 6.9 KiB +19 B (+0.3%) 7.8 KiB ✅
Claude Live turn WebSocket decoded 59.7 KiB 59.7 KiB 0 B (0.0%) 66.4 KiB ✅
Claude Live turn messages 9 9 0 (0.0%) 21 ✅

Baseline: 00b2ffc · PR result: 7f57442 · Source CI: success

Scenario and decoded snapshot size

10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.

  • Codex decoded thread snapshot: 115.6 KiB
  • Claude decoded thread snapshot: 116.3 KiB

Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed.

@rynfar
rynfar merged commit 5dad0b0 into pylon Sep 17, 2026
19 checks passed
@rynfar
rynfar deleted the upstream/2026-09-17-antigravity-health branch September 17, 2026 06:14

This branch was successfully deployed

1 active deployment
Preview — 7f57442b Deployed Sep 17, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:L vouch:trusted PR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants