Repository navigation
fix(mobile): expose thread rows and project picker rows to accessibility (#152) - #718
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
Thread transfer impact✅ Thread transfer remains within every enforced ceiling.
Baseline: Scenario and decoded snapshot size10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.
Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed. |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #152
Root Cause
Rows are wrapped in
<ControlPillMenu shouldOpenOnLongPress>, which renders@react-native-menu/menu'sThemedMenuView(MenuViewImplementation: UIButton). In iOS UIKit,UIButtoninitializes withisAccessibilityElement = YESby default. Under React Native Fabric,RCTViewComponentView.mmevaluatesself.contentView.isAccessibilityElement, which returnedYESfor the menu overlay button without an accessibility label. In UIKit, marking a view as an accessibility element causes the accessibility engine to treat it as a leaf element, completely ignoring and hiding all child views (the rowPressables, thread title text, labels, and badges) from VoiceOver and accessibility inspection.NewTaskRouteScreen):Project rows in the "Choose project" sheet rendered a bare
Pressablewithout accessibility role, label, or state attributes. The iOS toolbar "Add project" button and empty-state buttons were also missing accessibility labels/roles.Fix
@react-native-menu/menuiOS patch (MenuViewImplementation.swift) to setself.isAccessibilityElement = !shouldOpenOnLongPressalongsideself.isUserInteractionEnabled = !shouldOpenOnLongPress. In long-press mode, the overlay button is excluded from the accessibility tree, allowing VoiceOver to traverse into the wrapped child views.NewTaskRouteScreenproject picker rows to configureaccessible,accessibilityRole="button",accessibilityLabel(viagetProjectScopeAccessibilityLabel), andaccessibilityState={{ disabled }}.getProjectScopeAccessibilityLabel.Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.