Repository navigation
fix(antigravity): stop commands left running after a turn - #867
Merged
Merged
Conversation
Adapt T3 cdb26fe63549df633751ab0eed145b9357b30a21 for Pylon's prompt, recovery, and session ownership.
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
Contributor
Thread transfer impact✅ Thread transfer remains within every enforced ceiling.
Baseline: Scenario and decoded snapshot size10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.
Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Antigravity can leave native commands running after its prompt and turn complete. Stop previously sent
session/cancelto an idle session, which had no prompt to cancel, so those commands kept running. This closes the session when Stop finds promoted commands and emits their stopped task receipts. A later turn can resume the saved native session.Pylon's ProviderService can recover a new session as soon as the adapter reports the old one stopped, while the old stopped-task and exit events are still queued. This PR fences an explicit Antigravity Stop to its exact live incarnation until ProviderService ingests the old exit event, after the stopped-task receipt. Concurrent Stops share the fence, and recovery rechecks it at the incarnation swap. The fence survives caller interruption and releases on active-prompt Stop. If the exit is missing after 15 seconds, Stop fails explicitly while the fence remains in place; recovery resumes after a late exit or adapter replacement/server restart. Ordinary absent-session recovery remains available. This adapts T3
cdb26fe63549df633751ab0eed145b9357b30a21(#13388) from frozen cycle #865.Validation: 219 focused tests across ProviderService, Antigravity adapter, recovery, and steering;
vp run --filter t3 typecheck; scopedvp lintandvp fmt. Tests cover idle promoted commands, active prompt Stop, new-turn rejection during close, ProviderService receipt ordering under a blocked subscriber, missing exit timeout and fail-closed retry, late exit after timeout, interrupted Stop caller, concurrent Stops, recovery/Stop race, and already absent session recovery. Native Antigravity process behavior was not exercised by these harness tests.Model: GPT-6 Sol (low reasoning), overseen by Codex.