Skip to content

fix(observability): ignore malformed OTEL resource attributes - #870

Merged
rynfar merged 1 commit into
pylonfrom
upstream/2026-09-26-otel-attributes
Sep 27, 2026
Merged

rynfar merged 1 commit into
pylonfrom
upstream/2026-09-26-otel-attributes

Conversation

@rynfar

@rynfar rynfar commented Sep 27, 2026 •

Copy link
Copy Markdown
Collaborator

A malformed OTEL_RESOURCE_ATTRIBUTES could make Effect's OTLP exporter fail during server or desktop startup. This ports T3 source 87d84280192195b338e27acf2333771a13d04e61 (#13469): parse attributes once, log a fixed warning without exposing values when decoding fails, and provide the accepted attributes to the exporters. Pylon's T3CODE_OTEL_SDK_DISABLED override remains intact.

Focused verification: 21 shared configuration tests, including empty, valid, encoded, and malformed values; scoped lint and formatting; shared, server, and desktop typechecks.

Model: GPT-6 Sol (low reasoning), overseen by Codex in Pylon harness.


View with [code]smith Autofix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need. Autofix is disabled.

…ops startup (#13469)

Signed-off-by: Yordis Prieto <yordis.prieto@gmail.com>
(cherry picked from commit 87d84280192195b338e27acf2333771a13d04e61)
@vercel

vercel Bot commented Sep 27, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated
pylon-marketing Ignored Ignored Preview Sep 27, 2026 5:38am UTC

@github-actions github-actions Bot added the vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. label Sep 27, 2026
@rynfar
rynfar merged commit 3b9730b into pylon Sep 27, 2026
19 checks passed
@github-actions

Copy link
Copy Markdown
Contributor

Thread transfer impact

✅ Thread transfer remains within every enforced ceiling.

Provider Metric Main baseline This PR Impact PR ceiling
Codex Total thread wire 14.0 KiB 14.0 KiB +6 B (+0.0%) 15.1 KiB ✅
Codex Thread snapshot wire 7.3 KiB 7.3 KiB +4 B (+0.1%) 7.3 KiB ✅
Codex Live turn WebSocket wire 6.7 KiB 6.7 KiB +2 B (+0.0%) 7.8 KiB ✅
Codex Live turn WebSocket decoded 58.0 KiB 58.0 KiB 0 B (0.0%) 66.4 KiB ✅
Codex Live turn messages 9 9 0 (0.0%) 21 ✅
Claude Total thread wire 14.0 KiB 14.0 KiB +32 B (+0.2%) 15.1 KiB ✅
Claude Thread snapshot wire 7.2 KiB 7.3 KiB +18 B (+0.2%) 7.3 KiB ✅
Claude Live turn WebSocket wire 6.7 KiB 6.8 KiB +14 B (+0.2%) 7.8 KiB ✅
Claude Live turn WebSocket decoded 58.9 KiB 58.9 KiB 0 B (0.0%) 66.4 KiB ✅
Claude Live turn messages 9 9 0 (0.0%) 21 ✅

Baseline: d126c14 · PR result: 8c5787e · Source CI: success

Scenario and decoded snapshot size

10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.

  • Codex decoded thread snapshot: 115.7 KiB
  • Claude decoded thread snapshot: 116.4 KiB

Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed.

@rynfar
rynfar deleted the upstream/2026-09-26-otel-attributes branch September 27, 2026 05:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:M vouch:trusted PR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants