Repository navigation
fix(web): adopt six upstream chat fixes for the composer bar, question rows and file links - #924
Merged
Merged
Conversation
… chips (#13909) (cherry picked from commit 88fbc2cac77ff2bf0d406c44754ecd8014976f5f)
(cherry picked from commit 55ec55b1fb2e65f2736ff8420ae0373210c1911e)
Ported by hand from upstream eeea71a88108c375c04853f58c298a518a54acaf (#13713); Pylon's hero and draft-error markup carry their own classes.
(cherry picked from commit 916ec94f93da686303f878d506a760efd13506c1)
…scroll Ported by hand from upstream 29abbf9b424b122c52bb20dccffac68bee367c09 (#13555). Pylon's strip also tracks hosted composer controls and has-content state, so only the label text measurement changes.
Ported by hand from upstream dd582dee36976ccfd2a896cf50c3ee957ca7b9be (#13083). Pylon's offline notice keeps its description and Connections action.
Contributor
Thread transfer impact✅ Thread transfer remains within every enforced ceiling.
Baseline: Scenario and decoded snapshot size10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.
Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Six small web chat defects that upstream T3 Code fixed and Pylon still had (catch-up cycle for #865):
scrollWidthand lost its tail.z-ai/glm-5.3orQwen/Qwen2.5-Coderbecame a file chip.Fix
29abbf9b424b122c52bb20dccffac68bee367c09(#13555)eeea71a88108c375c04853f58c298a518a54acaf(#13713)dd582dee36976ccfd2a896cf50c3ee957ca7b9be(#13083)916ec94f93da686303f878d506a760efd13506c1(#12900)88fbc2cac77ff2bf0d406c44754ecd8014976f5f(#13909)55ec55b1fb2e65f2736ff8420ae0373210c1911e(#12449)., which opens the singleton files explorer and suppresses the file read.Pylon adaptations
useLabelsOverfloware untouched.displayText) anduser-input.answer-submittedfolding are kept. Upstream'sAgentSpawnRowcontext in the conflict is not part of this source and was not brought in. The newgetQuestionTextPreviewtests are appended to Pylon's existinguserInput.test.ts.Exclusions
electron={isElectron}on the hosted-static onboarding header belongs to a different upstream commit and is not included.apps/mobile/modules/t3-markdown-text/src/markdownLinks.ts) and so gets the model-id guard; it does not callworkspaceRelativeFilePath.Verification
vp test runonpackages/client-runtime/src/markdownLinks.test.ts,packages/client-runtime/src/work-log/userInput.test.ts,apps/web/src/components/chat/MessagesTimeline.test.tsx,apps/web/src/components/files/FilePreviewPanel.test.ts,apps/web/src/markdown-links.test.ts,apps/web/src/rightPanelStore.test.ts,apps/web/src/workspaceBasenameLookup.test.ts,apps/mobile/src/lib/markdownLinks.test.ts: 8 files, 329 tests passed (rerun after rebase).vp run -F @t3tools/web typecheckandvp run -F @t3tools/client-runtime typecheck: both ran and exited 0 with no errors (run before the final rebase, which only brought in server commits).vp linton the 18 changed files: 0 errors; the warnings reported are on lines this PR does not touch.vp fmt --checkon the 18 changed files: clean.Limits
No rendered-client pass was done: no browser, desktop or simulator run. The composer measurement, drag region and offline notice are verified by typecheck and review only.
Refs #865
Model: Claude Opus 5.5. Harness: Claude Code in Pylon. Workflow: review-t3-upstream skill.
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.