Skip to content

fix(web): adopt upstream hotkey, header and code-block polish - #982

Merged
rynfar merged 1 commit into
pylonfrom
upstream/2026-10-02-web-polish
Oct 2, 2026
Merged

rynfar merged 1 commit into
pylonfrom
upstream/2026-10-02-web-polish

Conversation

@rynfar

@rynfar rynfar commented Oct 2, 2026 •

Copy link
Copy Markdown
Collaborator

Records plain keys and Tab in hotkey settings while preserving modifier requirements for global snapshot shortcuts. Fixes constrained PR checks status, terminal-toggle spacing, and Dockerfile code-block icons, and removes outdated restart advice.

Sources:

  • 71a90ae70e3ff880396363809bd9bfcfd520f30c — Adopted; added snapshot guard regression tests.
  • ced865c224ebb7dd2cbd0f2931d6e33559b9343a — Adopted; preserves workflow approval controls and accessible labels.
  • fa6262db3107a4c95b6ff611113e6fa0753e5948 — Adopted; Pylon already advertises and gates restart continuation by capability.
  • 20012ebd80b06a4c10ab0e78893822e7f873b2a8 — Adopted.
  • 67f640093ffea1adaa585949d87e4bc2010b0810 — Adopted.
  • 5a574a77d1bef579b01d137b81888f68eabf7d4b — Adapted; removed only the duplicated ID-tie test. Retained distinct sidebar tests, Pylon-specific coverage, and live planPinnedReorder callers.

Verification: 418 tests passed across nine focused suites; web typecheck and changed-file formatting passed. Lint exited successfully with three pre-existing ChatView unused-variable warnings.

Remaining scope: browser geometry, responsive collapse, and panel animations were not exercised.

Part of upstream cycle #981. Ported with Codex (relay); pushed and opened by Claude Opus 5.5 (Claude Code).


View with [code]smith Autofix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need. Autofix is disabled.

Upstream cycle #981, group A:

71a90ae70e3ff880396363809bd9bfcfd520f30c - Adopted: record plain keys and Tab in hotkey settings, preserve modifier requirements for global snapshot shortcuts, and add snapshot guard regression coverage.
ced865c224ebb7dd2cbd0f2931d6e33559b9343a - Adopted: collapse constrained PR check summaries to their icon while preserving workflow approval controls and accessible labels.
fa6262db3107a4c95b6ff611113e6fa0753e5948 - Adopted: remove blanket older-server update advice; Pylon advertises restart continuation and gates the setting on every connected target capability.
20012ebd80b06a4c10ab0e78893822e7f873b2a8 - Adopted: reserve header action spacing and remove the hidden maximize control from flex flow.
67f640093ffea1adaa585949d87e4bc2010b0810 - Adopted: map dockerfile fences to Dockerfile for the Docker icon.
5a574a77d1bef579b01d137b81888f68eabf7d4b - Adapted: remove only the creation-time ID tie test duplicated by client-runtime sortActiveThreadsByOrderKey coverage. Retain distinct creation/re-entry and pinned-reorder cases, Pylon drag/drop and optimistic preview tests, and the live planPinnedReorder import/export and callers.

Validation: 418 tests across nine focused suites; web typecheck; changed-file lint and formatting; git diff --check. Lint retains three pre-existing ChatView unused-variable warnings. Browser geometry and animations were not exercised.
@github-actions github-actions Bot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. size:M labels Oct 2, 2026
@rynfar
rynfar merged commit 1449e9a into pylon Oct 2, 2026
21 checks passed
@rynfar
rynfar deleted the upstream/2026-10-02-web-polish branch October 2, 2026 06:03
@github-actions

github-actions Bot commented Oct 2, 2026

Copy link
Copy Markdown
Contributor

Thread transfer impact

✅ Thread transfer remains within every enforced ceiling.

Provider Metric Main baseline This PR Impact PR ceiling
Codex Total thread wire 14.0 KiB 14.0 KiB −6 B (−0.0%) 15.1 KiB ✅
Codex Thread snapshot wire 7.3 KiB 7.3 KiB −8 B (−0.1%) 7.3 KiB ✅
Codex Live turn WebSocket wire 6.7 KiB 6.7 KiB +2 B (+0.0%) 7.8 KiB ✅
Codex Live turn WebSocket decoded 58.0 KiB 58.0 KiB 0 B (0.0%) 66.4 KiB ✅
Codex Live turn messages 9 9 0 (0.0%) 21 ✅
Claude Total thread wire 14.0 KiB 14.0 KiB +80 B (+0.6%) 15.1 KiB ✅
Claude Thread snapshot wire 7.3 KiB 7.3 KiB +18 B (+0.2%) 7.3 KiB ✅
Claude Live turn WebSocket wire 6.7 KiB 6.8 KiB +62 B (+0.9%) 7.8 KiB ✅
Claude Live turn WebSocket decoded 58.8 KiB 58.9 KiB +88 B (+0.1%) 66.4 KiB ✅
Claude Live turn messages 8 10 +2 (+25.0%) 21 ✅

Baseline: 0088440 · PR result: 915ceb0 · Source CI: success

Scenario and decoded snapshot size

10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.

  • Codex decoded thread snapshot: 115.7 KiB
  • Claude decoded thread snapshot: 116.5 KiB

Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:M vouch:trusted PR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant