Update fz_find_table_within_bounds call for revised API. - #5070
Merged
Conversation
The MuPDF C API has changed to take a pointer to an optional options struct. For now we just make PyMuPDF pass NULL so it behaves as before. Ideally we should offer a way to parse options and pass a populated struct in too, but this is enough to avoid tests dying.
JorjMcKie
approved these changes
Jul 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The MuPDF C API has changed to take a pointer to an optional options struct. For now we just make PyMuPDF pass NULL so it behaves as before.
Ideally we should offer a way to parse options and pass a populated struct in too, but this is enough to avoid tests dying.