Skip to content

GH-122869: Fix JIT build - #122936

Merged
brandtbucher merged 2 commits into
python:mainfrom
faster-cpython:fix-122869
Aug 12, 2024
Merged

brandtbucher merged 2 commits into
python:mainfrom
faster-cpython:fix-122869

Conversation

@markshannon

@markshannon markshannon commented Aug 12, 2024 •

Copy link
Copy Markdown
Member

Override automatically generated optimizer cases, to get build working.

@ZeroIntensity

Copy link
Copy Markdown
Member

Trying to build on this patch results in the following error:

/usr/bin/ld: Python/optimizer_analysis.o: in function `optimize_uops':
/home/zero/Projects/cpython/Python/optimizer_analysis.c:466:(.text+0x570c): undefined reference to `_Py_uop_abstractcontext_fini'
/usr/bin/ld: /home/zero/Projects/cpython/Python/optimizer_analysis.c:460:(.text+0x57e6): undefined reference to `_Py_uop_abstractcontext_fini'
/usr/bin/ld: /home/zero/Projects/cpython/Python/optimizer_analysis.c:483:(.text+0x5864): undefined reference to `_Py_uop_abstractcontext_fini'
/usr/bin/ld: Python/sysmodule.o: in function `sys__clear_internal_caches_impl':
/home/zero/Projects/cpython/./Python/sysmodule.c:2181:(.text+0x2d9c): undefined reference to `_Py_Executors_InvalidateAll'
/usr/bin/ld: Modules/_opcode.o: in function `_opcode_get_executor_impl':
/home/zero/Projects/cpython/./Modules/_opcode.c:392:(.text+0x3e6): undefined reference to `_Py_GetExecutor'

@ZeroIntensity ZeroIntensity left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nevermind, forgot to make clean! Confirmed to fix my build problem from #122869

@brandtbucher
brandtbucher merged commit 1795d6c into python:main Aug 12, 2024
@brandtbucher brandtbucher changed the title GH-122869 Fix JIT build GH-122869: Fix JIT build Aug 12, 2024
blhsing pushed a commit to blhsing/cpython that referenced this pull request Aug 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants