Skip to content

gh-111178: fix UBSan failures for RemoteUnwinderObject#135539

Merged
pablogsal merged 1 commit into
python:mainfrom
picnixz:fix/ubsan/remote-inspection-111178
Jun 15, 2025
Merged

gh-111178: fix UBSan failures for RemoteUnwinderObject#135539
pablogsal merged 1 commit into
python:mainfrom
picnixz:fix/ubsan/remote-inspection-111178

Conversation

@picnixz

@picnixz picnixz commented Jun 15, 2025

Copy link
Copy Markdown
Member

This fixes the following

./python -m test test_external_inspection
...
Objects/object.c:3195:5: runtime error: call to function RemoteUnwinder_dealloc through pointer to incorrect function type 'void (*)(struct _object *)'
/home/picnix/lib/python/cpython/./Modules/_remote_debugging_module.c:2903: note: RemoteUnwinder_dealloc defined here

@pablogsal pablogsal merged commit 54e29ea into python:main Jun 15, 2025
46 checks passed
@pablogsal

Copy link
Copy Markdown
Member

Thanks 🙏

@picnixz

picnixz commented Jun 15, 2025

Copy link
Copy Markdown
Member Author

You're welcome. We can backport this if you want but I don't know which versions are affected (I am not on my dev session)

@picnixz picnixz deleted the fix/ubsan/remote-inspection-111178 branch June 15, 2025 19:01
@pablogsal pablogsal added the needs backport to 3.14 bugs and security fixes label Jun 15, 2025
@miss-islington-app

Copy link
Copy Markdown

Thanks @picnixz for the PR, and @pablogsal for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 15, 2025
…nGH-135539)

(cherry picked from commit 54e29ea)

Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
@pablogsal

Copy link
Copy Markdown
Member

Yeah let's backport for sure

@bedevere-app

bedevere-app Bot commented Jun 15, 2025

Copy link
Copy Markdown

GH-135547 is a backport of this pull request to the 3.14 branch.

@bedevere-app bedevere-app Bot removed the needs backport to 3.14 bugs and security fixes label Jun 15, 2025
shuimu5418 pushed a commit to shuimu5418/cpython001 that referenced this pull request Jun 16, 2025
encukou added a commit to encukou/cpython that referenced this pull request Jun 17, 2025
encukou added a commit to encukou/cpython that referenced this pull request Jun 17, 2025
encukou added a commit to encukou/cpython that referenced this pull request Jun 17, 2025
lkollar pushed a commit to lkollar/cpython that referenced this pull request Jun 19, 2025
Pranjal095 pushed a commit to Pranjal095/cpython that referenced this pull request Jul 12, 2025
taegyunkim pushed a commit to taegyunkim/cpython that referenced this pull request Aug 4, 2025
Agent-Hellboy pushed a commit to Agent-Hellboy/cpython that referenced this pull request Aug 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants