-
-
Notifications
You must be signed in to change notification settings - Fork 34.7k
gh-119670: Add force keyword only argument to shlex.quote
#148846
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
jb2170
wants to merge
17
commits into
python:main
Choose a base branch
from
jb2170:shlex-quote-force
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+46
−5
Open
Changes from all commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
6a51ccb
shlex: Implement `force` parameter behavior for `shlex.quote`
jb2170 36abcf2
shlex: Make `force` a keyword only argument in `shlex.quote`
jb2170 3b493e6
shlex tests: Add testForceQuote
jb2170 ca02f2b
shlex: Update documentation to mention `shlex.quote`'s `force` kwarg
jb2170 e2eed91
Add blurb entry for gh-119670: Add force keyword only argument to `sh…
jb2170 92c680f
Add whatsnew entry for `shlex.quote` gaining `force` kwarg
jb2170 cf31d96
shlex.quote: improve formatting
jb2170 2c45177
shlex.quote tests: Remove comments
jb2170 ef4a412
shlex.quote tests: Remove another comment
jb2170 a29eabb
shlex tests: Remove misplaced comment
jb2170 71b2a42
Tweak whatsnew and news entry for shlex.quote based on picnixz's review
jb2170 2cb6dbf
Tweak shlex.quote docs and doctring based on picnixz's review
jb2170 6429221
Tweak shlex.quote docs example of using `force` based on picnixz's re…
jb2170 a753be2
Tweak shlex.quote comments based on picnixz's review
jb2170 e922280
Tweak shlex.quote tests based on picnixz's review
jb2170 a030aa4
shlex.quote: Move comment above `if` statement
jb2170 7781ca0
Move `shlex.quote` whatsnew entry from 3.15 to 3.16
jb2170 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 changes: 2 additions & 0 deletions
2
Misc/NEWS.d/next/Library/2026-04-21-06-30-59.gh-issue-119670.pMWZfY.rst
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,2 @@ | ||
| Add keyword-only parameter *force* to :func:`shlex.quote` to force quoting | ||
| a string, even if it is already safe for a shell without being quoted. |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.