gh-149083: Use sentinel for urllib.parse._UNSPECIFIED#149612
Open
JelleZijlstra wants to merge 3 commits into
Open
gh-149083: Use sentinel for urllib.parse._UNSPECIFIED#149612JelleZijlstra wants to merge 3 commits into
JelleZijlstra wants to merge 3 commits into
Conversation
This was added in 3.15; let's use a real sentinel instead of an ad-hoc list object.
JelleZijlstra
added
the
needs backport to 3.15
|
|
||
|
|
||
| _UNSPECIFIED = ['not specified'] | ||
| _UNSPECIFIED = sentinel("_UNSPECIFIED") |
Member
There was a problem hiding this comment.
Would not it look better in the help if use "<not specified>" as a name? This sentinel is not intended to be pickled or used by user. It is just a placeholder for the case when the user has not specified the argument.
Member
Author
There was a problem hiding this comment.
I used the repr= argument now that we have it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was added in 3.15; let's use a real sentinel instead of an ad-hoc list object.
Since it's new in 3.15, I think it's fine to apply the change to both 3.15 and main (cc @hugovk). I added a NEWS entry out of an abundance of caution.