Skip to content

gh-150501: Correct inspect.getattr_static docs signature#150504

Merged
picnixz merged 3 commits into
python:mainfrom
jonathandung:patch-2
May 30, 2026
Merged

gh-150501: Correct inspect.getattr_static docs signature#150504
picnixz merged 3 commits into
python:mainfrom
jonathandung:patch-2

Conversation

@jonathandung
Copy link
Copy Markdown
Contributor

@jonathandung jonathandung commented May 27, 2026 •
edited
Loading

@bedevere-app bedevere-app Bot added docs Documentation in the Doc dir skip news awaiting review labels May 27, 2026
@github-project-automation github-project-automation Bot moved this to Todo in Docs PRs May 27, 2026
@jonathandung jonathandung changed the title Fix various inspect.getattr_static documentation flaws, including in faulty code example attached gh-150501: Fix various inspect.getattr_static documentation flaws, including in faulty code example attached May 27, 2026
@bedevere-app bedevere-app Bot mentioned this pull request May 27, 2026
Open
picnixz
picnixz requested changes May 27, 2026
View reviewed changes
Comment thread Doc/library/inspect.rst
Comment thread Doc/library/inspect.rst Outdated
@bedevere-app
Copy link
Copy Markdown

bedevere-app Bot commented May 27, 2026

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

And if you don't make the requested changes, you will be poked with soft cushions!

@read-the-docs-community
Copy link
Copy Markdown

read-the-docs-community Bot commented May 27, 2026 •
edited
Loading

Documentation build overview

📚 cpython-previews | 🛠️ Build #32913712 | 📁 Comparing ea17b5a against main (776573c)

  🔍 Preview build  

12 files changed · ± 12 modified

± Modified

@jonathandung jonathandung mentioned this pull request May 27, 2026
Open
@jonathandung
Copy link
Copy Markdown
Contributor Author

jonathandung commented May 27, 2026

I have made the requested changes; please review again

@bedevere-app
Copy link
Copy Markdown

bedevere-app Bot commented May 27, 2026

Thanks for making the requested changes!

@picnixz: please review the changes made to this pull request.

@bedevere-app bedevere-app Bot requested a review from picnixz May 27, 2026 10:02
serhiy-storchaka
serhiy-storchaka approved these changes May 29, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@serhiy-storchaka serhiy-storchaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. 👍

@serhiy-storchaka serhiy-storchaka added needs backport to 3.13 bugs and security fixes needs backport to 3.14 bugs and security fixes needs backport to 3.15 pre-release feature fixes, bugs and security fixes labels May 29, 2026
@picnixz picnixz changed the title gh-150501: Fix various inspect.getattr_static documentation flaws, including in faulty code example attached gh-150501: Correct inspect.getattr_static docs signature May 30, 2026
@picnixz picnixz merged commit 678fd84 into python:main May 30, 2026
30 checks passed
@github-project-automation github-project-automation Bot moved this from Todo to Done in Docs PRs May 30, 2026
@miss-islington-app
Copy link
Copy Markdown

miss-islington-app Bot commented May 30, 2026

Thanks @jonathandung for the PR, and @picnixz for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14, 3.15.
🐍🍒⛏🤖

@bedevere-app
Copy link
Copy Markdown

bedevere-app Bot commented May 30, 2026

GH-150601 is a backport of this pull request to the 3.15 branch.

@bedevere-app bedevere-app Bot removed the needs backport to 3.15 pre-release feature fixes, bugs and security fixes label May 30, 2026
@bedevere-app
Copy link
Copy Markdown

bedevere-app Bot commented May 30, 2026

GH-150602 is a backport of this pull request to the 3.14 branch.

@bedevere-app bedevere-app Bot removed the needs backport to 3.14 bugs and security fixes label May 30, 2026
@bedevere-app
Copy link
Copy Markdown

bedevere-app Bot commented May 30, 2026

GH-150603 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app Bot removed the needs backport to 3.13 bugs and security fixes label May 30, 2026
picnixz pushed a commit that referenced this pull request May 30, 2026
@miss-islington @jonathandung
[3.15] gh-150501: Correct inspect.getattr_static docs signature (GH…
187982a 
…-150504) (#150601)

gh-150501: Correct `inspect.getattr_static` docs signature (GH-150504)
(cherry picked from commit 678fd84)

Co-authored-by: Jonathan Dung <jonathandung@yahoo.com>
picnixz pushed a commit that referenced this pull request May 30, 2026
@miss-islington @jonathandung
[3.14] gh-150501: Correct inspect.getattr_static docs signature (GH…
412c089 
…-150504) (#150602)

gh-150501: Correct `inspect.getattr_static` docs signature (GH-150504)
(cherry picked from commit 678fd84)

Co-authored-by: Jonathan Dung <jonathandung@yahoo.com>
picnixz pushed a commit that referenced this pull request May 30, 2026
@miss-islington @jonathandung
[3.13] gh-150501: Correct inspect.getattr_static docs signature (GH…
3a15d16 
…-150504) (#150603)

gh-150501: Correct `inspect.getattr_static` docs signature (GH-150504)
(cherry picked from commit 678fd84)

Co-authored-by: Jonathan Dung <jonathandung@yahoo.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@serhiy-storchaka serhiy-storchaka serhiy-storchaka approved these changes

@picnixz picnixz picnixz approved these changes

Assignees

No one assigned

Labels

docs Documentation in the Doc dir skip news

Projects

Docs PRs
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jonathandung @serhiy-storchaka @picnixz