Repository navigation
[3.15] gh-150922: Fix test_cmd libedit assertion in test_bang_completion_without_do_shell (GH-156623) - #157155
Merged
serhiy-storchaka merged 1 commit intoOct 10, 2026
Conversation
…on_without_do_shell (pythonGH-156623) GNU readline retypes the full completed word after tab completion, but libedit redraws only the untyped suffix following a cursor-forward escape sequence. Assert on the common suffix ('ello') instead of the literal 'hello' bytes so the test passes on both backends. (cherry picked from commit 0b4c7da) Co-authored-by: Shardul Deshpande <iamsharduld@users.noreply.github.com>
Member
|
fine to wait for 3.15.1, it's just a small test improvement. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GNU readline retypes the full completed word after tab completion, but
libedit redraws only the untyped suffix following a cursor-forward
escape sequence. Assert on the common suffix ('ello') instead of the
literal 'hello' bytes so the test passes on both backends.
(cherry picked from commit 0b4c7da)
Co-authored-by: Shardul Deshpande iamsharduld@users.noreply.github.com