Fix reachability for frozenset and dict view narrowing#21151
Merged
Conversation
Fixes python#21143 (on the same lines as python#20704) I also update a comment that is a little out of date since python#20863 and code in checkexpr.py that is out of date for modern typeshed
Contributor
|
According to mypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅ |
JukkaL
pushed a commit
that referenced
this pull request
Apr 28, 2026
JukkaL
pushed a commit
that referenced
this pull request
Apr 30, 2026
nicopauss
pushed a commit
to Intersec/lib-common
that referenced
this pull request
Jun 4, 2026
##### [\`v1.20.1\`](https://github.com/python/mypy/blob/HEAD/CHANGELOG.md#Mypy-1201) - Always disable sync in SQLite cache (Ivan Levkivskyi, PR [21184](python/mypy#21184)) - Temporarily skip few base64 tests (Ivan Levkivskyi, PR [21193](python/mypy#21193)) - Revert `dict.__or__` typeshed change (Ivan Levkivskyi, PR [21186](python/mypy#21186)) - Fix narrowing for match case with variadic tuples (Shantanu, PR [21192](python/mypy#21192)) - Avoid narrowing `type[T]` in type calls (Shantanu, PR [21174](python/mypy#21174)) - Fix regression for catching empty tuple in except (Shantanu, PR [21153](python/mypy#21153)) - Fix reachability for frozenset and dict view narrowing (Shantanu, PR [21151](python/mypy#21151)) - Fix narrowing with chained comparison (Shantanu, PR [21150](python/mypy#21150)) - Avoid narrowing to unreachable at module level (Shantanu, PR [21144](python/mypy#21144)) - Allow dangerous identity comparisons to `Any` typed variables (Shantanu, PR [21142](python/mypy#21142)) - `--warn-unused-config` should not be a strict flag (Ivan Levkivskyi, PR [21139](python/mypy#21139)) ##### [\`v1.20.0\`](python/mypy@v1.19.1...v1.20.0) Renovate-Branch: renovate/r2026-mypy-1.x Change-Id: I88dbcfe5e6938c1401f9ffdda71a9a5e9703324a Priv-Id: ac1477044856e83cc49e7b2b61d5068c572e0b50
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #21143 (on the same lines as #20704, i.e. there still exists a deeper fix that could be made)
I also update a comment that is a little out of date since #20863 and code in checkexpr.py that is out of date for modern typeshed