Autoprofile fails if submodule contains a .py with with an invalid module name. #395

Activity

1. TTsangSC commented on Aug 30, 2025

   

   TTsangSC

   on Aug 30, 2025

   Collaborator

   More actions

   Sorry for the radio silence on this issue, was busy with #391 last week and my vacation the week before.

   Frankly I was caught by surprise, I'd have guessed that invalid module names should've been excluded by default. But it seems that both static analysis and pkgutil are all too happy to leave them be, and so we end up with stuff like

   try:
       import mypkg.utils.foo-v1  # This is syntactically invalid
   except ImportError:  # This normally handles failed imports
       ...
   else:  # This handles the profiling of module contents upon successful import
       ...

   in the module written by line_profiler.autoprofile.eager_preimports.write_eager_import_module().

   I've since pushed a fix at #397.
2. Erotemic

   closed this as completedin #397on Oct 7, 2025