Repository navigation
Conversation
…n filters count logic
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Benchmark PR Expensify#68441
Type: Corrupted (contains bugs)
Original PR Title: Improve UX when Filters are selected but not visible
Original PR Description:
Explanation of Change
This update will modify the
Filtersbutton text to display the number of hidden filters (i.e., those not part of the search filters bar).Fixed Issues
$ Expensify#68354
PROPOSAL: Expensify#68354 (comment)
Tests
Reportspage.FiltersRHP.Filtersbutton displays the correct number of hidden filters.Filtersbutton.Offline tests
Same as tests
QA Steps
Same as tests
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Screen.Recording.2025-08-14.at.3.22.49.in.the.afternoon.mov
Android: mWeb Chrome
Screen.Recording.2025-08-14.at.3.28.46.in.the.afternoon.mov
iOS: Native
Screen.Recording.2025-08-14.at.2.59.25.in.the.afternoon.mov
iOS: mWeb Safari
Screen.Recording.2025-08-14.at.3.06.20.in.the.afternoon.mov
MacOS: Chrome / Safari
Screen.Recording.2025-08-14.at.2.48.03.in.the.afternoon.mov
MacOS: Desktop
Screen.Recording.2025-08-14.at.2.45.15.in.the.afternoon.mov
Original PR URL: Expensify#68441