Skip to content

Treats commit messages without bodies as always invalid #37

Closed

Description

I'm getting check failures for trivial commits where the short summary is sufficient. In this case, I see others working around the check by repeating themselves in the body. It encourages developers to write pointless nonsense just to get around the check.

A commit message without a body is not necessarily an error. We do need good code review practice to ensure that commit messages are appropriate, and that includes the reviewer checking that the commit message is reasonable. I don't think automation can help with this here, and in this case it's counterproductive.

Qualcomm does require Signed-off-by: in the body and that's fine.

This check should therefore accept commit messages with just that trailer and nothing else in the body.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions