Skip to content

feat(desktop): establish secure Electron foundation - #128

Merged
qwen-code-dev-bot merged 1 commit into
mainfrom
issue/127-secure-electron-foundation
Jul 18, 2026
Merged

qwen-code-dev-bot merged 1 commit into
mainfrom
issue/127-secure-electron-foundation

Conversation

@qwen-code-dev-bot

Copy link
Copy Markdown
Owner

Summary

Establish the first secure Electron foundation for the macOS-first desktop roadmap. This slice adds the main-process lifecycle, a one-method context-isolated preload bridge, hardened BrowserWindow defaults, local-only shell loading, navigation and popup denial, and the build step required to bundle a sandbox-compatible CommonJS preload.

Motivation

The desktop roadmap needs a real Electron process boundary before renderer layout, terminal continuity, and live workbench behavior can be added safely. Keeping this boundary in its own PR makes the security contract independently reviewable.

Reviewer Test Plan

  • Verify the desktop window keeps sandboxing and context isolation enabled while renderer-side Node integration remains disabled.
  • Verify the preload surface exposes only bootstrap state and cannot dispatch arbitrary IPC channels.
  • Verify the main process blocks top-level navigation and new windows and loads no remote URL.
  • Verify the standard CLI build, typecheck, unit, integration, and smoke commands remain green.

Verification

  • Build: pass
  • Typecheck: pass
  • Unit: 901 pass
  • Integration: 265 pass
  • Smoke: 5 pass

Linux Xvfb interaction and the macOS runner screenshot remain separate governed desktop slices.

Closes #127
Part of #106

@qwen-code-dev-bot

Copy link
Copy Markdown
Owner Author

E2E verification

  • Repository: qwen-code-dev-bot/oh-my-cli
  • Pull request: #128
  • Commit: 7076b7fe756ff264f380c27fd98887e0e08d9cf4
  • Evidence mode: terminal
  • Result: PASS
Scenario Command Exit Duration
integration npm run test:integration 0 11.827s
smoke npm run smoke 0 2.814s

E2E evidence

Full immutable report

@qwen-code-dev-bot
qwen-code-dev-bot merged commit f1677ad into main Jul 18, 2026
2 checks passed
@qwen-code-dev-bot
qwen-code-dev-bot deleted the issue/127-secure-electron-foundation branch July 18, 2026 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Desktop: establish the secure Electron process boundary

1 participant