content: reposition the site as Product Engineer - #56
Merged
Merged
Conversation
The copy described a beginner ("building a solid base", "starting a software
engineering degree", "since January 2022") and no longer matches the author.
- Hero third line: "And build solutions" -> "And build products end to end".
The other three lines are untouched.
- Section title: "Software Engineer" -> "Product Engineer".
- Tagline: now names what the role actually covers, first commit to production.
- Body: rewritten around backend and system design, the Node.js/TypeScript/
NestJS/Java stack, and production systems handling real money. Kept the
existing 2-then-1 paragraph split so the two-column grid still balances.
- Footer year: 2023 -> 2026.
Markup, classes and component structure are unchanged; only text nodes differ.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
site.ts is the single source for the page title, description, og:title, og:description, siteName and the twitter card, so one edit updates every metadata surface. Also widens the keyword list with Product Engineer, Node.js, NestJS and Java. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
The greeting, presentation and footer specs assert the exact strings that changed, so they would fail against the new copy. Constants only; no change to what the tests actually check. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
🦋 Changeset detectedLatest commit: 8aea866 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
The longer description grew the page by 28px (chromium 4156 -> 4184, mobile 5514 -> 5586), so the committed baselines no longer matched. Regenerated with the `update_snapshots` workflow job rather than locally, since baselines only render identically to the check that asserts them when they are produced in the same environment. Taken on Ubuntu 24.04.5 LTS with the pinned playwright 1.63.0, matching the test job. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
changeset-bot flagged that the PR would merge without a version bump. The copy and metadata are user-facing, and package.json's version feeds site.ts's rum.version, so the Datadog tag should move with the content. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Rewrites the landing page copy and metadata. The site was written in 2023 and still described a beginner — "building a solid base", "starting a software engineering degree", "since January 2022" — which no longer matches the author.
Content and metadata only. No design, colour, typography, animation or component-structure changes: every edit is a text node inside markup that was left exactly as it was.
greetingSection.tsxpresentationSection.tsxfooterSection.tsxraferdev@2023→raferdev@2026config/site.tsnameanddescription_layout/metadata.tsxtests/section.{greetings,presentation,footer}.spec.tsThe new body is built around backend and system design, the Node.js / TypeScript / NestJS / Java stack, and production systems handling real money. It keeps the existing 2-then-1 paragraph split so the two-column grid still balances.
Why one edit covers every metadata surface
config/site.tsis the single source:title,description,og:title,og:description,siteNameand the wholetwitter:card all derive frommeta.name/meta.description. Verified in the generated HTML:A grep of the build for
Software Engineer,build solutions,Pragmatism and creativity,I have worked since 2019andraferdev@2023returns 0 — no stale copy survives.Verification
pnpm run check.eslint— cleanprettier --check— cleanpnpm run build— passesFor the reviewer
The screenshot baselines will fail and need regenerating. The copy changes the rendered page height, so the PNGs fixed in #55 are now stale. This is expected, not a regression. Fix with the job already on
main:Then commit the PNGs and the branch goes green.
One broken link found, deliberately left alone. Of 13 links checked,
https://myworldx.com/raferdevreturns 404.myworldx.com(200) and the repository (200) are fine — only the profile page is gone. The MyWorldx section stays as-is since the project is being picked back up; removing anything is the author's call.Two things worth a decision, not changed here:
config/site.ts:13—metadata.links.githubstill points athub.lumenfield.work/raferdev/landing-page, the old repo name. It only returns 200 because GitHub redirects renamed repos, and it disagrees withlinks.self.repository, which already usesrafer.dev.public/logos/, and each "planet" carries its own gradient, per-breakpoint absolute positioning and a Storybook story. That's layout work, which this PR deliberately avoids.