Skip to content

chore(assistant): remove external connectors and document MCP research - #282

Merged
chaxus merged 1 commit into
mainfrom
codex/remove-external-connectors
Oct 18, 2026
Merged

chaxus merged 1 commit into
mainfrom
codex/remove-external-connectors

Conversation

@chaxus

@chaxus chaxus commented Oct 18, 2026

Copy link
Copy Markdown
Member

Merge Verdict

[APPROVE] — Remove external connectors to match the application's account-free, browser-only scope.

45 files · +433 / -1728

Summary

  • Remove Google Drive and remote MCP connection controls, client code, OAuth API handler, deployment routing, and connector-only translations/styles.
  • Preserve local reference attachments, document readers, source citations, artifacts, optional model endpoints, and outbound WebMCP support.
  • Add a detailed technical investigation covering MCP architecture, Figma/Notion/Longbridge integration, browser OAuth/CORS constraints, industry approaches, and the decision to remove connectors.

Risk Analysis

Risk Level Mitigation
External sources become unavailable Intentional behavior change Update current documentation and mark previous connector plans as superseded. Local file attachments remain available.
Existing saved source metadata Low Retain citation/provenance metadata fields for compatibility. No storage migration.
Reference import and cancellation regressions Low Update all consumers of the moved reference modules; verify local attachment isolation, cancellation, limits, and offline behavior.

Design Decisions

  • Keep reference readers under references/, independent of any external service or account.
  • Remove the Google OAuth backend and its deployment route instead of retaining an unsupported connection entry.
  • Keep the service worker's generic /api/ exclusion so API responses cannot become offline assets.

Code Concerns

No actionable findings in the implementation review or follow-up consumer checks.

Verification

Check Result
Final-branch focused unit regression Passed: 103 tests across 8 files
Full unit suite before history cleanup Passed: 6,746 tests across 250 files
Reference/artifact browser regression before history cleanup Passed: 9 Playwright tests
TypeScript and lint before history cleanup Passed: pnpm run lint:ts
Formatting before history cleanup Passed: pnpm run format:check
Production build before history cleanup Passed: pnpm run build
Commit scope and patch integrity Passed: one commit above origin/main; tree matches applying only the connector-removal patch; git diff --check clean

Conclusion basis

  • Verified: the full checks above ran during implementation. The final branch drops an unrelated inherited URL-encoding fix; the connector-removal patch is unchanged, and the focused unit checks were rerun afterward.
  • Inferred from code: local-reference consumers and persisted provenance remain compatible with the renamed modules and retained metadata shape.
  • Not covered: production deployment and live third-party OAuth flows. Those connectors are removed by this PR.

@cloudflare-workers-and-pages

Copy link
Copy Markdown

Deploying document with  Cloudflare Pages  Cloudflare Pages

Latest commit: b466907
Status: ✅  Deploy successful!
Preview URL: https://e1327316.document-7hm.pages.dev
Branch Preview URL: https://codex-remove-external-connec.document-7hm.pages.dev

View logs

@chaxus
chaxus enabled auto-merge (rebase) October 18, 2026 09:31
@chaxus
chaxus merged commit 95c68f8 into main Oct 18, 2026
33 of 35 checks passed
@chaxus
chaxus deleted the codex/remove-external-connectors branch October 18, 2026 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant