Repository navigation
Conversation
This was referenced Oct 9, 2026
hxy91819
marked this pull request as ready for review
October 9, 2026 06:10
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The adapter still carries obsolete CLI/native backend paths after adopting SDK prompt execution, complicating authentication, session lifecycle and test coverage.
Evidence
The source diff removes CLI runner/native ACP/assistant-stream/settings-preload implementations and their obsolete tests. Existing SDK behavior assertions are retained or rewritten, and persisted ACP and SDK identities become explicitly separate.
Fix
Keep the SDK as the sole execution/authentication backend, simplify agent and storage handling, remove obsolete exports/implementations, and preserve SDK ACP regression coverage and stricter resume E2E assertions. Update usage and contributor documentation.
Depends on
fix/sdk-session-resume(linked issue #5; prerequisite PR pending). Unique scope isfix/sdk-session-resume..feature/sdk-only-backend: 25 files, 366 insertions and 4,982 deletions. Removing exported CLI/native APIs and changing persisted metadata is compatibility-sensitive, not merely dead-code cleanup. Existing consumers and older session metadata deserve explicit maintainer review.This source is not stacked on #4, skill-discovery, model-parameters, discovery-errors or permission-mode; mechanical merges against each of those branches conflict. Do not present their integration as independent. The session-fork and usage-ledger stacks both depend on this removal.
Validation
Fresh exact-source verification of validated source, not a descendant/aggregate substitution:
Tracked worktree remained clean after validation. Used a disposable detached worktree and its own frozen-lockfile Nub install. Opt-in real-model tests, where present, remained skipped; these results do not claim live authentication, billing or real sandbox containment.
Rebase, dependencies and evidence
Merge/review prerequisites first: #12.
Submission alias has the same tree as the verified source branch; current upstream main remains the source baseline. Overlapping implementations and compatibility limitations are documented above. Exact-source validation is now complete. This PR is ready for maintainer review; declared prerequisites and integration conflicts still constrain merge order.
Ready for review
Exact-source check, full default test suite and build all passed. The earlier source-verification gap is closed. Declared prerequisites remain merge-order constraints, not a reason to prevent review; this does not authorize merging unrelated prerequisite features.
Compatibility review: the loader accepts legacy
backendSessionIdmetadata as well as newsdkSessionId; the legacy-field regression passes. The public exportsCursorCliRunner,CursorNativeAcpClientandparseAuthStatusare intentionally removed. Library consumers using those exports must migrate to the SDK surface. Maintainer approval and an appropriate release/versioning decision are required; this PR does not claim API compatibility.