Repository navigation
Conversation
hxy91819
marked this pull request as ready for review
October 9, 2026 06:10
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
SDK model-discovery failure can be swallowed and converted into an Auto-only fallback catalog, making a failed session initialization appear usable.
Evidence
The former
getAvailableModelscaughtrunner.listModels()errors and continued with an empty list. The SDK runner also accepted an empty catalog. Added regressions assert propagation of discovery errors and rejection of empty SDK results.Fix
Propagate discovery failures, reject empty SDK catalogs, and register the session only after initial model discovery succeeds. Document the failure behavior instead of caching a misleading fallback.
No source-ancestry prerequisites beyond the upstream baseline. Unique scope is
upstream-main/20260924-d422bdd..fix/model-discovery-errors(five files). This branch conflicts with SDK-only removal in agent code/tests and with model-parameters in agent tests; integration must preserve both error handling and parameter enrichment.Validation
Fresh exact-source verification of validated source, not a descendant/aggregate substitution:
Tracked worktree remained clean after validation. Used a disposable detached worktree and its own frozen-lockfile Nub install. Opt-in real-model tests, where present, remained skipped; these results do not claim live authentication, billing or real sandbox containment.
Rebase, dependencies and evidence
Based directly on current upstream main; no unmerged ancestry prerequisite.
Submission alias has the same tree as the verified source branch; current upstream main remains the source baseline. Overlapping implementations and compatibility limitations are documented above. Exact-source validation is now complete. This PR is ready for maintainer review; declared prerequisites and integration conflicts still constrain merge order.
Ready for review
Exact-source check, full default test suite and build all passed. The earlier source-verification gap is closed. Declared prerequisites remain merge-order constraints, not a reason to prevent review; this does not authorize merging unrelated prerequisite features.