Repository navigation
Remove gen_cluster spill tests - #758
Merged
rapids-bot[bot] merged 1 commit intoOct 22, 2021
Merged
rapids-bot[bot] merged 1 commit into
rapids-bot[bot] merged 1 commit into
Conversation
The way coroutines are handled in Distributed test with gen_cluster was changed in dask/distributed#5446, breaking the two tests that still relied on gen_cluster. Since we don't encourage using using coroutines/yield, there's really little reason to keep those tests.
pentschev
added
3 - Ready for Review
3 tasks done
quasiben
approved these changes
Oct 22, 2021
quasiben
left a comment
quasiben
left a comment
Member
There was a problem hiding this comment.
Thanks @pentschev looks like the tests you are removing were already covered by test_cudf_cluster_device_spill
Member
|
@gpucibot merge |
Member
Author
|
Yes, that's right, we have other tests for checking that, but we were redundant on testing with |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The way coroutines are handled in Distributed test with gen_cluster was
changed in dask/distributed#5446, breaking the
two tests that still relied on gen_cluster. Since we don't encourage
using using coroutines/yield, there's really little reason to keep those
tests.