Skip to content

Add element to Shiny input#41

Merged
timelyportfolio merged 7 commits into
masterfrom
try-addelid
Jul 9, 2020
Merged

Add element to Shiny input#41
timelyportfolio merged 7 commits into
masterfrom
try-addelid

Conversation

@timelyportfolio

@timelyportfolio timelyportfolio commented Jun 29, 2020

Copy link
Copy Markdown
Collaborator

Normally in React this would be not be considered best practice but in the case of Shiny we know that element is stable across a session.

Also, many of the npm dependencies are out-of-date, so potentially at the risk of confusing this with that, went ahead and upgraded all npm dependencies. JS tests all passed.

https://github.com/react-R/reactvega/blob/master/srcjs/reactvega.jsx is an example usage of new functionality that allows us to add the el id to our Shiny input value for the purpose of referencing in Shiny with observe/observeEvent. I don't think there is any other way to accomplish otherwise.

@timelyportfolio

timelyportfolio commented Jun 29, 2020

Copy link
Copy Markdown
Collaborator Author
  • document change
  • add NEWS.md item
  • minor increment version

@timelyportfolio

timelyportfolio commented Jun 29, 2020

Copy link
Copy Markdown
Collaborator Author

@glin I have tested with reactable but would you be able to confirm that there is nothing breaking in these changes? Thanks so much.

The el change does not apply to htmlwidgets so hopefully nothing there, but there is a small chance that npm updates might affect.

@glin

glin commented Jul 6, 2020

Copy link
Copy Markdown
Contributor

@timelyportfolio Confirmed, all looks good here!

@timelyportfolio timelyportfolio merged commit a5d9869 into master Jul 9, 2020
@timelyportfolio timelyportfolio deleted the try-addelid branch September 14, 2024 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants