Repository navigation
feat: add manual Cocoapods installation info - #2204
Merged
thymikee merged 7 commits intoDec 13, 2023
Merged
Conversation
okwasniewski
commented
Dec 13, 2023
okwasniewski
force-pushed
the
feat/cocoapods-info
branch
from
December 13, 2023 13:08
59b8006 to
e7d2479
Compare
okwasniewski
force-pushed
the
feat/cocoapods-info
branch
from
December 13, 2023 13:34
e7d2479 to
0e66055
Compare
TMisiukiewicz
approved these changes
Dec 13, 2023
okwasniewski
force-pushed
the
feat/cocoapods-info
branch
from
December 13, 2023 13:59
0e66055 to
a0dcd97
Compare
thymikee
approved these changes
Dec 13, 2023
cipolleschi
approved these changes
Dec 13, 2023
cipolleschi
left a comment
cipolleschi
left a comment
Contributor
There was a problem hiding this comment.
Looks good to me.
I only left a couple of nits
| @@ -196,6 +203,7 @@ async function createFromTemplate({ | |||
| const installPodsValue = String(installCocoaPods); | |||
Contributor
There was a problem hiding this comment.
you already have this variable in didInstallPods (line125)
Contributor
Author
There was a problem hiding this comment.
As discussed here: #2204 (comment)
didInstallPods is used for a slightly different purpose (also to check if the user didn't specify his choice) and mixing those two made the code more complex.
Co-authored-by: Riccardo Cipolleschi <riccardo.cipolleschi@gmail.com>
thymikee
pushed a commit
that referenced
this pull request
Dec 13, 2023
* feat: add manual Cocoapods installation info * feat: apply review comments * fix: move logger.info out of nested if * fix: hide banner in CI * fix: check for Install cocoapods only on darwin * test: check if cocoapods instruction is shown in another test * Update packages/cli/src/commands/init/printRunInstructions.ts Co-authored-by: Riccardo Cipolleschi <riccardo.cipolleschi@gmail.com> --------- Co-authored-by: Riccardo Cipolleschi <riccardo.cipolleschi@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
This PR aims to:
Test Plan:
CI Green
Checklist