Repository navigation
refactor: adapt getSimulators() for OOT platforms - #2239
Merged
thymikee merged 1 commit intoJan 3, 2024
Merged
Conversation
okwasniewski
force-pushed
the
feat/remove-getSimulators
branch
from
January 3, 2024 09:58
020c91c to
13f520f
Compare
cipolleschi
approved these changes
Jan 3, 2024
cipolleschi
left a comment
Contributor
There was a problem hiding this comment.
I like that the code is much simpler now!
okwasniewski
marked this pull request as ready for review
January 3, 2024 10:00
Contributor
Author
|
As pointed out by @szymonrybczak (in private message) we can't remove
|
getSimulators()getSimulators() for OOT platforms
szymonrybczak
approved these changes
Jan 3, 2024
2 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
This PR removes
getSimulators()from createRun and adopts them for createLog. I've also added a handful info message from where we are tailing logs from:Test Plan:
Check if returned devices are the same.
Checklist