Repository navigation
fix(ios): prioritize simulators over devices - #2364
Merged
Merged
Conversation
Collaborator
Author
|
For some reason Windows Job is failing - all passes locally. |
szymonrybczak
force-pushed
the
fix/order-when-launching-app
branch
from
June 4, 2024 17:31
992d01d to
656790c
Compare
thymikee
approved these changes
Jun 5, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
In
run-ioscommand we prioritize simulators over devices:cli/packages/cli-platform-apple/src/commands/runCommand/createRun.ts
Line 225 in 992d01d
but we're launching app first on a device then on a simulator, in this PR I switched the order of launching app to align with logging and previous assumptions.
Test Plan:
Checklist