Skip to content

test: use agent-device for native e2e tests#13126

Open
thymikee wants to merge 48 commits into
react-navigation:mainfrom
thymikee:codex/agent-device-e2e-runner
Open

test: use agent-device for native e2e tests#13126
thymikee wants to merge 48 commits into
react-navigation:mainfrom
thymikee:codex/agent-device-e2e-runner

Conversation

@thymikee

Copy link
Copy Markdown

Summary

Replace native e2e CI from Maestro CLI to pinned agent-device@0.16.0 while keeping Maestro-compatible YAML flows.

Validation

  • yarn prettier --check scripts/agent-device.ts .github/workflows/e2e-ios.yml .github/workflows/e2e-android.yml example/package.json package.json CONTRIBUTING.md
  • git diff --check
  • node --check scripts/agent-device.ts
  • yarn agent-device --version -> 0.16.0
  • yarn install --immutable
  • yarn typecheck
  • commit hook: dependency alignment, types, lint, Jest suite (49 suites, 815 tests)

@netlify

netlify Bot commented May 28, 2026

Copy link
Copy Markdown

Deploy Preview for react-navigation-example ready!

Name Link
🔨 Latest commit d48e786
🔍 Latest deploy log https://app.netlify.com/projects/react-navigation-example/deploys/6a29b98c953637000871e4de
😎 Deploy Preview https://deploy-preview-13126--react-navigation-example.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@socket-security

socket-security Bot commented May 28, 2026

Copy link
Copy Markdown

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Addedagent-device@​0.17.27810010096100

View full report

@codecov

codecov Bot commented May 28, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 73.28%. Comparing base (bce29d6) to head (d48e786).
⚠️ Report is 116 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #13126      +/-   ##
==========================================
+ Coverage   72.24%   73.28%   +1.03%     
==========================================
  Files         238      241       +3     
  Lines        8391     9521    +1130     
  Branches     3480     3935     +455     
==========================================
+ Hits         6062     6977     +915     
- Misses       2274     2484     +210     
- Partials       55       60       +5     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@thymikee thymikee changed the title [codex] Use agent-device for native e2e tests test: use agent-device for native e2e tests May 28, 2026
@thymikee thymikee marked this pull request as ready for review May 31, 2026 15:11
@socket-security

socket-security Bot commented Jun 1, 2026

Copy link
Copy Markdown

All alerts resolved. Learn more about Socket for GitHub.

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

View full report

@thymikee thymikee force-pushed the codex/agent-device-e2e-runner branch 3 times, most recently from c963672 to a3beabe Compare June 3, 2026 16:58
@satya164

satya164 commented Jun 7, 2026

Copy link
Copy Markdown
Member

I'm not sure about removal of extendedWaitUntil: in favor of assertVisible:. Since there are animation, the wait feels more "correct". And if it's visible already then agent device shouldn't be failing or waiting there, should be same as assertVisible. If they aren't needed, lets revert them to keep it easier to see what changed.

Similar for the swipe changes. For drop in replacement, they should work as they were with explicit percentages.

The preloaded test may need a different approach instead of timing, which I can look into, but the changes seem like they won't test it properly.

@thymikee thymikee force-pushed the codex/agent-device-e2e-runner branch from 11b0283 to aa56c86 Compare June 8, 2026 07:25
@thymikee thymikee force-pushed the codex/agent-device-e2e-runner branch from 5490a55 to f07980e Compare June 8, 2026 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants