react-native upgrade will change the path of MainActivity.java, how to stay with the original path?

[iapolog2u]

Description

How to stay with the original path of MainActivity.java?

I have cloned the f8app project

then run react-native upgrade in this project

It will create MainActivity.java at pathandroid/app/src/main/java/com/f8v2/MainActivity.java instead of use the original path.

the original path is

android/app/src/main/java/com/facebook/f8/MainActivity.java

below is my operation

$ git clone git@github.com:fbsamples/f8app.git
$ cd f8app
$ npm install
$ ls android/app/src/main/java/com/facebook/f8
MainActivity.java
$ react-native upgrade
Upgrading project to react-native v0.28.0
...
   create android/app/src/main/java/com/f8v2/MainActivity.java

Reproduction

please see the description

Additional Information

• React Native version: 0.28.0+
• Platform: android
• Operating System: MacOS, Windows

[st0ffern]

@gnaykcin It will create new files as they are Breaking changes from 0.28 -> 0.29.
Please read docs or stack overflow:
https://github.com/facebook/react-native/releases/tag/v0.29.0

[iapolog2u]

@Stoffern thanks for your reply, actually it's not a problem of version.

It will create new files in other versions too, .e.g. 0.32.0

Looks like that it will create new files just based on the name in package.json instead of existing package name in android/app/src/main/AndroidManifest.xml, I have checked the code in upgrade process here https://github.com/facebook/react-native/blob/0.38-stable/local-cli/generator-android/index.js

    this.option('package', {
      desc: 'Package name for the application (com.example.app)',
      type: String,
      defaults: 'com.' + this.name.toLowerCase()
    });

...

    var javaPath = path.join.apply(
      null,
      ['android', 'app', 'src', 'main', 'java'].concat(this.options.package.split('.'))
    );
    this.fs.copyTpl(
      this.templatePath(path.join('package', '**')),
      this.destinationPath(javaPath),
      templateParams
    );

[mkonicek]

This issue looks like a question that would be best asked on StackOverflow.

StackOverflow is amazing for Q&A: it has a reputation system, voting, the ability to mark a question as answered. Because of the reputation system it is likely the community will see and answer your question there. This also helps us use the GitHub bug tracker for bugs only.

Will close this as this is really a question that should be asked on StackOverflow.

[mkonicek]

Yes, it will overwrite your changes. You'll have to edit the files manually after upgrading. We're working on a better tool based on git.

[stereodenis]

@mkonicek @the-ant how to upgrade RN with specific package name "com.organization.project"?

react-native-git-upgrade 0.42.0
git-upgrade info Check for updates 
git-upgrade info Using yarn 0.24.6 
git-upgrade info Read package.json files 
git-upgrade info Check declared version 
git-upgrade info Check matching versions 
git-upgrade info Check React peer dependency 
git-upgrade info Check that Git is installed 
git-upgrade info Get information from NPM registry 
git-upgrade info Upgrading to React Native 0.42.0, React ~15.4.1 
git-upgrade info Setup temporary working directory 
git-upgrade info Configure Git environment 
git-upgrade info Init Git repository 
git-upgrade info Add all files to commit 
warning: CRLF will be replaced by LF in android/gradlew.bat.
The file will have its original line endings in your working directory.
warning: CRLF will be replaced by LF in docs/api/Readme.md.
The file will have its original line endings in your working directory.
git-upgrade info Commit current project sources 
git-upgrade info Create a tag before updating sources 
git-upgrade info Generate old version template 
git-upgrade info Add updated files to commit 
git-upgrade info Commit old version template 
git-upgrade info Install the new version 
git-upgrade info Generate new version template 
git-upgrade info Add updated files to commit 
warning: CRLF will be replaced by LF in android/gradlew.bat.
The file will have its original line endings in your working directory.
git-upgrade info Commit new version template 
git-upgrade info Generate the patch between the 2 versions 
git-upgrade info Save the patch in temp directory 
git-upgrade info Reset the 2 temporary commits 
git-upgrade info Apply the patch 
error: patch failed: .gitignore:22
Falling back to three-way merge...
Applied patch to '.gitignore' with conflicts.
error: android/app/src/main/java/com/busforapp/MainApplication.java: does not exist in index
error: patch failed: android/build.gradle:5
Falling back to three-way merge...
Applied patch to 'android/build.gradle' with conflicts.
error: patch failed: ios/BusforApp.xcodeproj/project.pbxproj:22
Falling back to three-way merge...
Applied patch to 'ios/BusforApp.xcodeproj/project.pbxproj' with conflicts.
error: patch failed: ios/BusforApp.xcodeproj/xcshareddata/xcschemes/BusforApp.xcscheme:3
Falling back to three-way merge...
Applied patch to 'ios/BusforApp.xcodeproj/xcshareddata/xcschemes/BusforApp.xcscheme' cleanly.
error: patch failed: ios/BusforApp/AppDelegate.m:9
Falling back to three-way merge...
Applied patch to 'ios/BusforApp/AppDelegate.m' with conflicts.
git-upgrade WARN The upgrade process succeeded but there might be conflicts to be resolved. See above for the list of files that have merge conflicts. 
git-upgrade info Upgrade done 

[axelg12]

I'm experiencing the same thing when upgrading from 0.37 to 0.38 (Working my way up to the newest release). My package name in the manifest file com.manifestName.android but I always receive the error com/packageJSONname/MainApplication.java

@the-ant Do you remember the way you went?