Repository navigation
Fix bug when dispatching unique and non-unique events of the same type on the same target - #50988
Closed
rubennorte wants to merge 4 commits into
Closed
rubennorte wants to merge 4 commits into
rubennorte wants to merge 4 commits into
Conversation
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D73849222 |
Summary: Changelog: [internal] This just exposes some enum values and methods that we forgot to expose in a few interfaces. Reviewed By: javache Differential Revision: D73849221
Summary: Changelog: [internal] Just adding a test suite to verify the behavior of event dispatching in Fabric (especially around event priorities, automatic determination based on ContinuousStart/ContinuousEnd and unique events). This also surfaced a bug where we incorrectly batch unique and non-unique events together (see the disabled test). Differential Revision: D73849218
…0987) Summary: Changelog: [internal] This adds a new `isUnique` option in `RawEvent` to determine if it's unique (whether it should be coalesced with other unique events of the same type and target). This effectively makes `dispatchUniqueEvent` redundant, as we can use `dispatchEvent` with a `RawEvent` marked as unique. This will allow us to fix the bug we found in the new tests for event dispatching, where non-unique events of a given type where being coalesced with non-unique events of the same type. Differential Revision: D73849220
…e on the same target (#50988) Summary: Changelog: [internal] This fixes a potential bug where we coalesce unique events with non-unique ones of the same type and target. Not marked as a bug fix in the changelog because this wouldn't happen in practice, as we always dispatch events of a given type the same way (all unique or all non-unique). Differential Revision: D73849222
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D73849222 |
Contributor
|
This pull request has been merged in 030ca3c. |
5 of 8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Changelog: [internal]
This fixes a potential bug where we coalesce unique events with non-unique ones of the same type and target.
Not marked as a bug fix in the changelog because this wouldn't happen in practice, as we always dispatch events of a given type the same way (all unique or all non-unique).
Differential Revision: D73849222