Skip to content

Update debugRenderPhaseSideEffects behavior #12046

Description

@bvaughn

Follow up item for PR #12028

Within the context of an async tree, we should double-invoke the following methods:

  • constructor
  • render
  • static getDerivedStateFromProps
  • setState updater functions

The current implementation of debugRenderPhaseSideEffects is to also double-invoke several additional methods (eg will-mount, will-update, sCU, etc). This behavior should be removed.

We should also add a dev-warning if we detect any components within an async tree that contain the following methods:

  • componentWillMount (or UNSAFE_componentWillMount)
  • componentWillReceiveProps (or UNSAFE_componentWillReceiveProps)
  • componentWillUpdate (or UNSAFE_componentWillUpdate)

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions