Auto-assigned keys can conflict with user-specified ones

[sophiebits]

If you render

<div>
    <span key={1}>hello,</span>
    <span>world</span>
</div>

then React throws a duplicate-key error because the second span ("world") is assigned a key of 1, its index in the div's children.

Presumably it's best to simply avoid specifying only some keys but it would be nice if React could use separate namespaces for different key types (or at least provide a slightly more informative error message).

[sebmarkbage]

Thanks for this report. If you do this in a dynamic array, you would still have a warning to provide a key. I guess this can happen if you provide explicit keys on a static set (which you don't need to do). In this case we need a better error message.

As you suggest, it would be even better if we namespace auto-assigned keys.

[zpao]

I think 61b38b9 fixes this, right @sebmarkbage?

[sophiebits]

Right, this is fixed.

On Thu, Sep 5, 2013 at 10:29 PM, Paul O’Shannessy
notifications@github.com wrote:

I think 61b38b9 fixes this, right @sebmarkbage?

Reply to this email directly or view it on GitHub:
#180 (comment)