Skip to content

Review Process #23

Description

@arshadkazmi42

For reviewing we follow this process.

  • Add the list of all the section names (in english) in the pull request description, which reviewer will mark check as and when the review of each section is getting completed (For reference check this PR [Translation] - Getting Started #17 )
  • You should not resolve review feedback, you can add a comment or an 👍 emoji to every review comment once it's resolved and pushed.
  • A reviewer will review the changes and resolve the conversations

Review Phases

Activity

  1. pinned this issue on Mar 6, 2019
  2. saranshkataria commented on Mar 6, 2019

    @saranshkataria
    Contributor

    We should also add that if the file is large, add a list of sections so that the reviewer can check the ones we have reviewed?

  3. arshadkazmi42 commented on Mar 7, 2019

    @arshadkazmi42
    MemberAuthor

    We should also add that if the file is large, add a list of sections so that the reviewer can check the ones we have reviewed?

    Added this point also 👍

  4. saranshkataria commented on Mar 7, 2019

    @saranshkataria
    Contributor

    Also, try and have the section names in english so as to avoid any confusions if the translation for the heading changes

  5. added a commit that references this issue on Jul 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions