Skip to content

Fix gist link about promise in README.md#250

Merged
SimonFrings merged 1 commit into
reactphp:3.xfrom
SQKo:patch-1
Aug 28, 2023
Merged

Fix gist link about promise in README.md#250
SimonFrings merged 1 commit into
reactphp:3.xfrom
SQKo:patch-1

Conversation

@SQKo

@SQKo SQKo commented Aug 27, 2023

Copy link
Copy Markdown
Contributor

The link is no longer valid somehow so i looked up web archive to find the actual gist page

@WyriHaximus WyriHaximus left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting change, thanks for catching and PRing this 👍

@clue clue left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SQKo Thanks for taking the time to update this, LGTM! :shipit:

@SimonFrings SimonFrings left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@SimonFrings SimonFrings merged commit baf9ab5 into reactphp:3.x Aug 28, 2023
@SQKo SQKo deleted the patch-1 branch October 1, 2023 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants