fix(e2e): Do not print secret value from secret.Fixture.HaveNonEmptyKeyValue

[olivergondza]

It confuses openshift-ci secrets redaction

This was triggered by "verifies that the Dex client secret is sourced from a short-lived TokenRequest token and is correctly set in argocd-secret" printing JWT.

What type of PR is this?

Uncomment only one /kind line, and delete the rest.
For example, > /kind bug would simply become: /kind bug

/kind bug

/kind cleanup
/kind failing-test
/kind enhancement
/kind documentation
/kind code-refactoring

What does this PR do / why we need it:

Have you updated the necessary documentation?

• Documentation update is required by this PR.
• Documentation has been updated.

Which issue(s) this PR fixes:

Fixes #?

Test acceptance criteria:

• Unit Test
• E2E Test

How to test changes / Special notes to the reviewer:

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository YAML (base), Organization UI (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: 6177a329-c323-48ce-9eac-c049c9ceeb31

📥 Commits

Reviewing files that changed from the base of the PR and between efea41a and cc96d36.

📒 Files selected for processing (1)

• test/openshift/e2e/ginkgo/fixture/secret/fixture.go

🔗 Linked repositories identified

CodeRabbit considers these linked repositories for cross-repo context during reviews:

• argoproj-labs/argocd-operator (manual)

---

📝 Walkthrough

Summary by CodeRabbit

• Bug Fixes
  • Improved security by preventing secret contents from appearing in logs.
  • Secret validation now consistently reports whether a value is empty.

Walkthrough

The secret matcher no longer logs secret contents. It computes the empty-value status once, logs that status, and returns the inverse.

Changes

Secret matcher behavior

Layer / File(s)	Summary
Matcher logging and result test/openshift/e2e/ginkgo/fixture/secret/fixture.go	HaveNonEmptyKeyValue logs whether the value is empty and returns the computed non-empty status.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Merge Risk: ⚪ Minimal · up to cc96d

The change prevents secret values from being printed during end-to-end tests, reducing the chance of exposing sensitive output; no actionable merge-blocking risk remains.

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly identifies the fix that prevents secret values from being printed by the E2E fixture.
Description check	✅ Passed	The description explains that printed JWTs interfere with OpenShift CI secret redaction and identifies the affected fixture behavior.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

---

_{Comment @coderabbitai help to get the list of available commands.}

[varshab1210]

/lgtm

[varshab1210]

/approve

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: varshab1210

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [varshab1210]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment