Skip to content

Public build links to the internal-only "FB Internal Feedback Group" #170

Open

Description

@rbalicki2

The public Chrome Web Store build (0.9.17) shows two icons in the DevTools header. The one with the tooltip "FB Internal Feedback Group" links to https://fburl.com/ieftwi8l, which redirects to https://www.internalfb.com/intern/fburl/redirect/?s=ieftwi8l. Only people with access to Meta's internal network can open it.

Source:

  • function getInternalDevToolsFeedbackGroup() {
    return 'https://fburl.com/ieftwi8l';
    }
    (getInternalDevToolsFeedbackGroup)
  • <div className={styles.FeedbackLinks}>
    <Tooltip
    className={tooltipStyles.Tooltip}
    label="FB Internal Feedback Group"
    >
    <a
    href={process.env.DEVTOOLS_FEEDBACK_GROUP}
    target="_blank"
    rel="noopener noreferrer"
    >
    <Icon
    className={styles.IconSizeLarge}
    type="fb-feedback"
    />
    </a>
    </Tooltip>
    (the link, rendered from process.env.DEVTOOLS_FEEDBACK_GROUP)

Possible fix: leave the link out of public builds, for example by rendering it only when DEVTOOLS_FEEDBACK_GROUP is set and not setting it in the public build. The "Github Issues" link next to it already covers external feedback.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions