Repository navigation
fix(sdk): preserve repeatUntilOk retry results - #1156
Open
zakazaka95 wants to merge 1 commit into
Open
zakazaka95 wants to merge 1 commit into
zakazaka95 wants to merge 1 commit into
Conversation
Contributor
|
@zakazaka95 is attempting to deploy a commit to the Uneven Labs Team on Vercel. A member of the Team first needs to authorize it. |
[Medium impact] This PR appears safe to merge.
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
repeatUntilOkreturnstruewhen the first callback succeeds, but resolves toundefinedif success comes after a retry. The recursive call is awaited without returning its result. This helper is exported from the SDK.Changes
Related to #1150, which fixes the separate
pollApihelpers. This change does not modify those functions or their tests.Validation
git diff --checkpass.Tested on Windows with Node 24.14.0 and pnpm 10.33.0. UI/hooks lint and the full monorepo build were not run; this patch only changes the SDK helper, its tests and its changeset. No live transactions were sent.