Repository navigation
[685a33aa] Remove dead no_helpers_in_routers rule and stale router comments - #1500
Merged
roboco-app[bot] merged 2 commits intoNov 4, 2026
Conversation
… and router comments
|
Thanks for opening your first pull request on RoboCo! Quick checklist before review (most of these are enforced by CI, but worth a glance):
See CONTRIBUTING.md for the full workflow and the Code of Conduct for the community standards we follow. Welcome aboard — a maintainer will review shortly. |
roboco-app
Bot
merged commit Nov 4, 2026
cccda82
into
feature/backend/7c4c7675--5733333e
10 checks passed
roboco-app
Bot
deleted the
feature/backend/7c4c7675--5733333e--685a33aa
branch
November 4, 2026 05:36
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes the dead
no_helpers_in_routersrule and its comments from.roboco/conventions.yml, and rewords the posture and closing comments so they refer only to routes.no_helpers_in_routesis unchanged atwarn. Ayaml.safe_loadbefore/after diff shows only the routers rule disappeared, andmake gatepasses.Source of the 22
no_helpers_in_routersfindings: not this repo. roboco-api has norouters/directory and no module with aroutersleaf, so the rule could never fire here. The only references to the rule name in this repo are unit-test fixtures (tests/unit/conventions/test_scan.py,tests/unit/foundation/policy/conventions/). Rule names are built asno_{kind}s_in_{leaf}(roboco/conventions/scan.py:157), and the scan heuristic listsroutersas a route-module name (scan.py:50), so the rule is derived for any project that has arouters/directory. The 22 findings therefore come from another project's derived conventions or from stale hotspot-ledger data. I had no ledger access to confirm which.