Skip to content

[685a33aa] Remove dead no_helpers_in_routers rule and stale router comments - #1500

Merged
roboco-app[bot] merged 2 commits into
feature/backend/7c4c7675--5733333efrom
feature/backend/7c4c7675--5733333e--685a33aa
Nov 4, 2026
Merged

roboco-app[bot] merged 2 commits into
feature/backend/7c4c7675--5733333efrom
feature/backend/7c4c7675--5733333e--685a33aa

Conversation

@roboco-app

@roboco-app roboco-app Bot commented Nov 4, 2026 •

Copy link
Copy Markdown
Contributor

Removes the dead no_helpers_in_routers rule and its comments from .roboco/conventions.yml, and rewords the posture and closing comments so they refer only to routes. no_helpers_in_routes is unchanged at warn. A yaml.safe_load before/after diff shows only the routers rule disappeared, and make gate passes.

Source of the 22 no_helpers_in_routers findings: not this repo. roboco-api has no routers/ directory and no module with a routers leaf, so the rule could never fire here. The only references to the rule name in this repo are unit-test fixtures (tests/unit/conventions/test_scan.py, tests/unit/foundation/policy/conventions/). Rule names are built as no_{kind}s_in_{leaf} (roboco/conventions/scan.py:157), and the scan heuristic lists routers as a route-module name (scan.py:50), so the rule is derived for any project that has a routers/ directory. The 22 findings therefore come from another project's derived conventions or from stale hotspot-ledger data. I had no ledger access to confirm which.

@github-actions

github-actions Bot commented Nov 4, 2026

Copy link
Copy Markdown

Thanks for opening your first pull request on RoboCo!

Quick checklist before review (most of these are enforced by CI, but worth a glance):

  • make quality — ruff format check, ruff check, mypy, pytest (≥80% coverage), and the rest of the gate
  • Panel changes pass pnpm lint and pnpm exec tsc --noEmit (run from panel/)
  • No # noqa / # type: ignore shortcuts; pre-existing violations in touched files are fixed
  • Added an entry under ## [Unreleased] in CHANGELOG.md
  • Signed the CLA (the bot will prompt you on this PR)
  • Signed your commits — master requires verified signatures (SSH signing setup)
  • Updated any affected docs under docs/

See CONTRIBUTING.md for the full workflow and the Code of Conduct for the community standards we follow.

Welcome aboard — a maintainer will review shortly.

@github-actions github-actions Bot added the documentation Docs, README, CHANGELOG, governance files label Nov 4, 2026
@roboco-app
roboco-app Bot merged commit cccda82 into feature/backend/7c4c7675--5733333e Nov 4, 2026
10 checks passed
@roboco-app
roboco-app Bot deleted the feature/backend/7c4c7675--5733333e--685a33aa branch November 4, 2026 05:36
@github-project-automation github-project-automation Bot moved this from Backlog to Done in RoboCo Kanban Nov 4, 2026
@github-actions github-actions Bot locked and limited conversation to collaborators Nov 4, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

0 participants