Background
In `combined_raw_datasets_generator.py` line 256, the temp directory suffix is hardcoded as the string `"can_we_use_urn_here"`:
```python
tmp_path = self._tmpdir_manager.get_suffix_path("can_we_use_urn_here").absolute()
```
This is clearly a placeholder left over from development. It makes error messages confusing — e.g.:
```
CRITICAL:root:Missing requirements file: /tmp/tmpw1w6hz80/3/can_we_use_urn_here/requirements.yml
```
Expected behaviour
The suffix should use the actual URN (or URL/repo name) of the location being resolved, so error messages are self-explanatory.
Suggested fix
Pass the URN from `current_location_handler` into `get_suffix_path(...)` once it is available at that point in the call chain.
Security constraint
Git URLs may contain embedded credentials (e.g. `https://token:x-oauth-basic@github.com/org/repo\`). The suffix must never include usernames, passwords, or tokens — these must be stripped before the URL is used as a path component.
Background
In `combined_raw_datasets_generator.py` line 256, the temp directory suffix is hardcoded as the string `"can_we_use_urn_here"`:
```python
tmp_path = self._tmpdir_manager.get_suffix_path("can_we_use_urn_here").absolute()
```
This is clearly a placeholder left over from development. It makes error messages confusing — e.g.:
```
CRITICAL:root:Missing requirements file: /tmp/tmpw1w6hz80/3/can_we_use_urn_here/requirements.yml
```
Expected behaviour
The suffix should use the actual URN (or URL/repo name) of the location being resolved, so error messages are self-explanatory.
Suggested fix
Pass the URN from `current_location_handler` into `get_suffix_path(...)` once it is available at that point in the call chain.
Security constraint
Git URLs may contain embedded credentials (e.g. `https://token:x-oauth-basic@github.com/org/repo\`). The suffix must never include usernames, passwords, or tokens — these must be stripped before the URL is used as a path component.