Close database connections (if applicable) on CachedSession.__aexit__ - #148
Merged
Conversation
JWCook
force-pushed
the
close-db-on-ctx-exit
branch
from
January 4, 2023 21:11
19245cc to
270b7e9
Compare
JWCook
changed the title
Codecov Report
@@ Coverage Diff @@
## main #148 +/- ##
==========================================
+ Coverage 95.13% 95.15% +0.01%
==========================================
Files 11 11
Lines 1008 1012 +4
Branches 180 180
==========================================
+ Hits 959 963 +4
Misses 34 34
Partials 15 15
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
(not automatically done since not used with ClientSession)
JWCook
force-pushed
the
close-db-on-ctx-exit
branch
from
January 4, 2023 23:49
270b7e9 to
9384f00
Compare
JWCook
marked this pull request as ready for review
January 4, 2023 23:50
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(hopefully) fixes #147