Skip to content

fix: click-to-filter converts a Contains dimension filter to Select instead of being a no-op - #9933

Merged
nishantmonu51 merged 1 commit into
mainfrom
nishant/fix-click-filter-contains
Sep 24, 2026
Merged

nishantmonu51 merged 1 commit into
mainfrom
nishant/fix-click-filter-contains

Conversation

@nishantmonu51

Copy link
Copy Markdown
Collaborator

With a Contains (LIKE) filter applied on a dimension, clicking a value in an explore chart, dimension table, leaderboard, time dimension table, canvas leaderboard or pivot, or the global search did nothing. This is a regression from 0.89, introduced with the unified expression filter component in #9746.

  • toggleValue and appendSelectedValues on DimensionFilterManager only mutated selectedValues, but commit() rebuilds the expression from inputText while in Contains mode, so the click was dropped and no notification fired.
  • They now switch the manager to Select and clear the search text first. The clicked values become the selection, exclude is preserved (NLIKE becomes NIN), and the existing "Converted filter type to Select" toast fires through the unchanged commit() logic.
  • removeSelectedValues is left alone: Contains mode holds no selected values, so converting there would clear the filter with nothing to replace it. In List mode also keeps its mode on click, since a click already works correctly there.
  • Adds ExpressionFilterManager.spec.ts cases for toggle, append and remove from Contains mode, including the notification.

Checklist:

  • Covered by tests
  • Ran it and it works as intended
  • Reviewed the diff before requesting a review
  • Checked for unhandled edge cases
  • Linked the issues it closes
  • Checked if the docs need to be updated. If so, create a separate Linear DOCS issue
  • Intend to cherry-pick into the release branch
  • I'm proud of this work!

Click to filter from charts, tables, leaderboards, pivots and search calls
toggleValue / appendSelectedValues on the DimensionFilterManager, which only
mutated selectedValues. commit() rebuilds the expression from inputText while
in Contains mode, so the click was silently dropped and no conversion
notification fired. Restores the 0.89 behaviour: the filter converts to Select
with the clicked values and the "converted to Select" toast is shown.
@nishantmonu51 nishantmonu51 added the blocker A release blocker issue that should be resolved before a new release label Sep 23, 2026
@nishantmonu51
nishantmonu51 merged commit 9f9e3c4 into main Sep 24, 2026
16 checks passed
@nishantmonu51
nishantmonu51 deleted the nishant/fix-click-filter-contains branch September 24, 2026 05:47
nishantmonu51 added a commit that referenced this pull request Sep 24, 2026
…9933)

Click to filter from charts, tables, leaderboards, pivots and search calls
toggleValue / appendSelectedValues on the DimensionFilterManager, which only
mutated selectedValues. commit() rebuilds the expression from inputText while
in Contains mode, so the click was silently dropped and no conversion
notification fired. Restores the 0.89 behaviour: the filter converts to Select
with the clicked values and the "converted to Select" toast is shown.

(cherry picked from commit 9f9e3c4)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

blocker A release blocker issue that should be resolved before a new release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants