Repository navigation
fix: click-to-filter converts a Contains dimension filter to Select instead of being a no-op - #9933
Merged
Merged
Conversation
Click to filter from charts, tables, leaderboards, pivots and search calls toggleValue / appendSelectedValues on the DimensionFilterManager, which only mutated selectedValues. commit() rebuilds the expression from inputText while in Contains mode, so the click was silently dropped and no conversion notification fired. Restores the 0.89 behaviour: the filter converts to Select with the clicked values and the "converted to Select" toast is shown.
AdityaHegde
approved these changes
Sep 24, 2026
nishantmonu51
added a commit
that referenced
this pull request
Sep 24, 2026
…9933) Click to filter from charts, tables, leaderboards, pivots and search calls toggleValue / appendSelectedValues on the DimensionFilterManager, which only mutated selectedValues. commit() rebuilds the expression from inputText while in Contains mode, so the click was silently dropped and no conversion notification fired. Restores the 0.89 behaviour: the filter converts to Select with the clicked values and the "converted to Select" toast is shown. (cherry picked from commit 9f9e3c4)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With a Contains (
LIKE) filter applied on a dimension, clicking a value in an explore chart, dimension table, leaderboard, time dimension table, canvas leaderboard or pivot, or the global search did nothing. This is a regression from 0.89, introduced with the unified expression filter component in #9746.toggleValueandappendSelectedValuesonDimensionFilterManageronly mutatedselectedValues, butcommit()rebuilds the expression frominputTextwhile in Contains mode, so the click was dropped and no notification fired.NLIKEbecomesNIN), and the existing "Converted filter type to Select" toast fires through the unchangedcommit()logic.removeSelectedValuesis left alone: Contains mode holds no selected values, so converting there would clear the filter with nothing to replace it. In List mode also keeps its mode on click, since a click already works correctly there.ExpressionFilterManager.spec.tscases for toggle, append and remove from Contains mode, including the notification.Checklist: