Repository navigation
fix: restore measure filters on comparison accessors (_delta, _delta_perc, _percent_of_total) - #9939
Merged
Merged
Conversation
Measure filters on `<measure>_delta`, `<measure>_delta_perc` and `<measure>_percent_of_total` were dropped when parsing the filter param. `JoinerFilterManager.parse` keyed the measure manager on the suffixed identifier, which is not a measure in the metrics view, so the manager was never created. Strip the suffix with the existing `stripMeasureSuffix` helper so the chip is created for the base measure; `reconcile` already reads the comparison type back from the having expression.
AdityaHegde
approved these changes
Sep 24, 2026
nishantmonu51
added a commit
that referenced
this pull request
Sep 24, 2026
Measure filters on `<measure>_delta`, `<measure>_delta_perc` and `<measure>_percent_of_total` were dropped when parsing the filter param. `JoinerFilterManager.parse` keyed the measure manager on the suffixed identifier, which is not a measure in the metrics view, so the manager was never created. Strip the suffix with the existing `stripMeasureSuffix` helper so the chip is created for the base measure; `reconcile` already reads the comparison type back from the having expression. (cherry picked from commit 8d44276)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Measure filters on comparison accessors were silently dropped by the unified expression filter refactor (#9746). Restores them.
havingpost-processor puts the raw identifier from the URL (e.g.impressions_delta) into the subquery's measure list.JoinerFilterManager.parsethen looked up a measure spec by that suffixed name, found nothing, and dropped the filter.stripMeasureSuffixhelper so the manager is keyed on the base measure.MeasureFilterManager.reconcilealready maps the having expression back to the right comparison type viamapExprToMeasureFilter, andcommitrebuilds the suffix from the type, so no double suffix and the subquery measure list stays the base measure (same as 0.89)._delta,_delta_percand_percent_of_total: chip created for the base measure with the right type/value, condition applied once, URL param round trips unchanged.Reproducing steps (on
main):Impressions→% change from→> 10, grouped byPublisher. The URL getsf.AdBids_metrics=publisher having (impressions_delta_perc GT 0.1).Impressionschip shows% change > 10and the filter is applied.The same happens for
impressions_delta gt 10(absolute change) andimpressions_percent_of_total gt 0.25(percent of total). Plainimpressions gt 10was unaffected.Checklist: