Skip to content

fix: dimension table search ignored when the dashboard has no active filters (getDimensionFilterWithSearch) - #9951

Merged
nishantmonu51 merged 1 commit into
mainfrom
nishant/fix-dimension-search-without-filters
Sep 25, 2026
Merged

nishantmonu51 merged 1 commit into
mainfrom
nishant/fix-dimension-search-without-filters

Conversation

@nishantmonu51

@nishantmonu51 nishantmonu51 commented Sep 24, 2026 •

Copy link
Copy Markdown
Collaborator
  • On an explore with an expanded dimension table and no active filters, typing in the search box changes nothing: the list stays the same and no query is issued for the search text.
  • Since the unified expression filter refactor (refac: unified expression filter component across explore, canvas, alerts and reports #9746), the dashboard's where filter is undefined when there are no active filters. getDimensionFilterWithSearch returned undefined in that case, so the search text was dropped and the dimension table query ran without a where clause. Any active filter on the dashboard masked the bug.
  • Treat an undefined filter as an empty AND so the search clause is still appended. This also covers the TDD search, dimension table exports and pivot search, which use the same helper.
  • Added unit tests for the undefined filter cases.

Checklist:

  • Covered by tests
  • Ran it and it works as intended
  • Reviewed the diff before requesting a review
  • Checked for unhandled edge cases
  • Linked the issues it closes
  • Checked if the docs need to be updated. If so, create a separate Linear DOCS issue
  • Intend to cherry-pick into the release branch
  • I'm proud of this work!

…filters

`getDimensionFilterWithSearch` returned undefined when the where filter was
undefined, which is now the case for a dashboard with no active filters since
the unified expression filter refactor (#9746). The search text was dropped
and the dimension table query ran without a where clause.

Treat an undefined filter as an empty AND so the search clause is still added.
@nishantmonu51
nishantmonu51 merged commit 46d77b5 into main Sep 25, 2026
19 of 20 checks passed
@nishantmonu51
nishantmonu51 deleted the nishant/fix-dimension-search-without-filters branch September 25, 2026 05:55
nishantmonu51 added a commit that referenced this pull request Sep 25, 2026
…filters (#9951)

`getDimensionFilterWithSearch` returned undefined when the where filter was
undefined, which is now the case for a dashboard with no active filters since
the unified expression filter refactor (#9746). The search text was dropped
and the dimension table query ran without a where clause.

Treat an undefined filter as an empty AND so the search clause is still added.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants