Repository navigation
fix: scheduled report filters dropped on save and hidden when editing (ScheduledReportDialog) - #9982
Merged
Merged
Conversation
- `ScheduledReportDialog` read the report's `where` from `filters.topLevelJoiner[metricsViewName]`, which is always undefined, so every explore report was saved without its filters. Read `topLevelJoiner.expr[metricsViewName]` instead, as the alert form does. - `FiltersForm` synced its filters from the page URL, which cleared a report's saved filters as soon as the edit dialog opened. Skip URL sync: the form owns these filters. - Add a component test that mounts the edit dialog and checks the query sent on save, and a reopen assertion in the reports e2e test.
AdityaHegde
approved these changes
Oct 2, 2026
| ], | ||
| ); | ||
| updatedAggregationRequest.where = filters?.topLevelJoiner[metricsViewName]; | ||
| updatedAggregationRequest.where = |
Collaborator
There was a problem hiding this comment.
Weird that there was no lint error throw before.
AdityaHegde
pushed a commit
that referenced
this pull request
Oct 5, 2026
…#9982) - `ScheduledReportDialog` read the report's `where` from `filters.topLevelJoiner[metricsViewName]`, which is always undefined, so every explore report was saved without its filters. Read `topLevelJoiner.expr[metricsViewName]` instead, as the alert form does. - `FiltersForm` synced its filters from the page URL, which cleared a report's saved filters as soon as the edit dialog opened. Skip URL sync: the form owns these filters. - Add a component test that mounts the edit dialog and checks the query sent on save, and a reopen assertion in the reports e2e test.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ScheduledReportDialogset the query'swherefromfilters.topLevelJoiner[metricsViewName], which is alwaysundefined. It now readsfilters.topLevelJoiner.expr[metricsViewName], as the alert form does.FiltersFormsynced its filter manager from the page URL. The report page URL carries no filters, so a report's saved filters were cleared as soon as the edit dialog opened. The form now skips URL sync, since the filters belong to the report or alert in the form.FiltersFormis shared with the alert form.syncStoreWithSourcecall fromFiltersForm: that file will conflict, and fix: delayed metrics spec load not retaining expression filters #9974's version supersedes this one there. fix: delayed metrics spec load not retaining expression filters #9974 still needs thewherefix.Steps to reproduce:
Creating a report from an explore that has filters applied hits the same bug: the report is saved without them.
Checklist: